fix: allow kube-apiserver to reach DevSpaces webhook (fixes #419)#430
Open
gferreir wants to merge 1 commit into
Open
fix: allow kube-apiserver to reach DevSpaces webhook (fixes #419)#430gferreir wants to merge 1 commit into
gferreir wants to merge 1 commit into
Conversation
Contributor
|
@pittar I know you have a lot more experience with DevSpaces. Any thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #419
Problem
When applying the
aggregate/overlays/defaultoverlay, syncing theCheClusterresource fails with a webhook timeout:The existing
instance/base/network-policy.yamlrestricts ingress to theopenshift-devspacesnamespace to only accept traffic from pods within that same namespace. The kube-apiserver runs with host networking on control plane nodes and is not part of any Kubernetes namespace, so its calls to the mutating webhook server (port 9443) are blocked by this policy.Fix
Add a second
NetworkPolicy(allow-webhook-from-apiserver) that explicitly allows ingress on port 9443 without afromselector. In Kubernetes, an ingress rule withportsbut nofromclause permits traffic from any source, including the kube-apiserver on host network.This keeps the existing broad ingress restriction in place while carving out a narrow exception for the webhook port only.