ci: add Slack PR notification workflow#31
Conversation
stevefulme1
had a problem deploying
to
external-ci
GitHub Actions
Failure
stevefulme1
force-pushed
the
slack-pr-notifications
branch
from
2d8c044 to
21715b6
Compare
Send Slack notifications on PR open, close, merge, reopen, and review events. GitHub context values are passed through env variables to prevent shell injection via crafted PR titles or usernames.
stevefulme1
force-pushed
the
slack-pr-notifications
branch
from
21715b6 to
ed3b2ed
Compare
Fix shellcheck SC2086 (unquoted variable) and SC2129 (individual redirects) in the notification details step.
burigolucas
left a comment
burigolucas
left a comment
There was a problem hiding this comment.
I fully agree with the new workflow, but please see my comments to some specific files that need to be addressed.
There was a problem hiding this comment.
We have added very import information for first-time contributors and maintainers in this file which is removed by this PR. I suggest to remove this change and keep the original file from the target branch.
There was a problem hiding this comment.
Good catch — reverted CONTRIBUTING.md to keep the project-specific contribution guide. The scaffolding files shouldn't have been bundled with the workflow change.
There was a problem hiding this comment.
We already have the LICENSE file with the GNU GPL. What is the value for adding this new file?
There was a problem hiding this comment.
Agreed — removed COPYING since LICENSE already covers GPL-3.0.
There was a problem hiding this comment.
Please, add a link to this file in the repository README under the section ## Documentation
There was a problem hiding this comment.
Done — added SECURITY.md link to the README Documentation section.
- Revert CONTRIBUTING.md to preserve project-specific contribution guide - Remove COPYING file (LICENSE already provides GPL-3.0) - Add SECURITY.md link to README Documentation section
- Revert CODE_OF_CONDUCT.md, CONTRIBUTING.md to main (handled in PR redhat-cop#31) - Remove COPYING and SECURITY.md (handled in PR redhat-cop#31) - Add explicit permissions block to gitleaks workflow - Bump gitleaks-action from v2 to v3
docs: regenerate network_mgmt README after OVN layer2 merge
2 participants
Summary
SLACK_WEBHOOK_URLrepo secret to be configuredTest plan
SLACK_WEBHOOK_URLsecret to the repo🤖 Generated with Claude Code