Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version and toolchain in go.mod to versions 1.25.0 and 1.26.0, which are currently unreleased and will cause build failures. It also introduces a large number of vendored dependencies. The review feedback identifies the invalid Go versions and suggests reverting to a stable release like 1.24. Furthermore, it questions the inclusion of the vendor/ directory, recommending a reliance on Go modules to minimize repository size and maintenance overhead.
go.mod
Outdated
| go 1.25.0 | ||
|
|
||
| toolchain go1.24.5 | ||
| toolchain go1.26.0 |
There was a problem hiding this comment.
The Go version 1.25.0 and toolchain go1.26.0 are not valid released versions of Go (Go 1.24 is the current major version). This will cause build failures in standard environments. Please use a valid stable version such as 1.24.
| @@ -0,0 +1,28 @@ | |||
| //go:build kubernetes_protomessage_one_more_release | |||
There was a problem hiding this comment.
The vendor/ directory is being added to the repository. Unless there is a specific requirement for vendoring (e.g., restricted network access during builds), it is generally recommended to rely on Go modules and exclude the vendor/ directory from version control to keep the repository size manageable and avoid maintenance overhead.
gshikhar2021
force-pushed
the
fix/Dep-Bump
branch
from
a2cb258 to
a55bea7
Compare
gshikhar2021
force-pushed
the
fix/Dep-Bump
branch
from
a55bea7 to
5de6426
Compare
gshikhar2021
force-pushed
the
fix/Dep-Bump
branch
from
5de6426 to
a488d53
Compare
go.mod
Outdated
| @@ -2,7 +2,7 @@ module github.com/redhat-data-and-ai/unstructured-data-controller | |||
|
|
|||
| go 1.24.4 | |||
|
|
||
| go 1.24.4 | ||
|
|
||
| toolchain go1.24.5 |
There was a problem hiding this comment.
dont we need to do go mod tidy and go mod vendor once
- Dep bump are failing because of go version
gshikhar2021
force-pushed
the
fix/Dep-Bump
branch
from
a488d53 to
423b18f
Compare
2 participants
Upgrade go version as dep bump is failing due to go version