-
Notifications
You must be signed in to change notification settings - Fork 5
Add chunking strategies using Docling #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pradeepto
wants to merge
4
commits into
redhat-data-and-ai:main
Choose a base branch
from
pradeepto:using-docling-for-chunking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c96e972
Add Docling chunking strategies and skip document processing for Do…
pradeepto 3789fde
Add spec validation and simplify DocumentProcessorConfig handling
pradeepto b4f9615
Implement Chunker interface for Docling chunkers
pradeepto 9e6adf9
Use async endpoints for Docling chunking
pradeepto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| /* | ||
| Copyright 2026. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestValidateSpec(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| spec UnstructuredDataProductSpec | ||
| wantErr bool | ||
| }{ | ||
| { | ||
| name: "docling hierarchical with DocumentProcessorConfig set returns error", | ||
| spec: UnstructuredDataProductSpec{ | ||
| ChunksGeneratorConfig: ChunksGeneratorConfig{ | ||
| Strategy: ChunkingStrategyDoclingHierarchical, | ||
| }, | ||
| DocumentProcessorConfig: &DocumentProcessorConfig{ | ||
| Type: "docling", | ||
| }, | ||
| }, | ||
| wantErr: true, | ||
| }, | ||
| { | ||
| name: "docling hybrid with DocumentProcessorConfig set returns error", | ||
| spec: UnstructuredDataProductSpec{ | ||
| ChunksGeneratorConfig: ChunksGeneratorConfig{ | ||
| Strategy: ChunkingStrategyDoclingHybrid, | ||
| }, | ||
| DocumentProcessorConfig: &DocumentProcessorConfig{ | ||
| Type: "docling", | ||
| }, | ||
| }, | ||
| wantErr: true, | ||
| }, | ||
| { | ||
| name: "docling hierarchical without DocumentProcessorConfig returns no error", | ||
| spec: UnstructuredDataProductSpec{ | ||
| ChunksGeneratorConfig: ChunksGeneratorConfig{ | ||
| Strategy: ChunkingStrategyDoclingHierarchical, | ||
| }, | ||
| }, | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "docling hybrid without DocumentProcessorConfig returns no error", | ||
| spec: UnstructuredDataProductSpec{ | ||
| ChunksGeneratorConfig: ChunksGeneratorConfig{ | ||
| Strategy: ChunkingStrategyDoclingHybrid, | ||
| }, | ||
| }, | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "non-docling strategy with DocumentProcessorConfig set returns no error", | ||
| spec: UnstructuredDataProductSpec{ | ||
| ChunksGeneratorConfig: ChunksGeneratorConfig{ | ||
| Strategy: ChunkingStrategyRecursiveCharacter, | ||
| }, | ||
| DocumentProcessorConfig: &DocumentProcessorConfig{ | ||
| Type: "docling", | ||
| }, | ||
| }, | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "non-docling strategy without DocumentProcessorConfig returns no error", | ||
| spec: UnstructuredDataProductSpec{ | ||
| ChunksGeneratorConfig: ChunksGeneratorConfig{ | ||
| Strategy: ChunkingStrategyMarkdown, | ||
| }, | ||
| }, | ||
| wantErr: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| err := tt.spec.ValidateSpec() | ||
| if (err != nil) != tt.wantErr { | ||
| t.Errorf("ValidateSpec() error = %v, wantErr %v", err, tt.wantErr) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestIsDoclingChunkingStrategy(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| strategy ChunkingStrategy | ||
| want bool | ||
| }{ | ||
| { | ||
| name: "docling hierarchical", | ||
| strategy: ChunkingStrategyDoclingHierarchical, | ||
| want: true, | ||
| }, | ||
| { | ||
| name: "docling hybrid", | ||
| strategy: ChunkingStrategyDoclingHybrid, | ||
| want: true, | ||
| }, | ||
| { | ||
| name: "recursive character", | ||
| strategy: ChunkingStrategyRecursiveCharacter, | ||
| want: false, | ||
| }, | ||
| { | ||
| name: "markdown", | ||
| strategy: ChunkingStrategyMarkdown, | ||
| want: false, | ||
| }, | ||
| { | ||
| name: "token", | ||
| strategy: ChunkingStrategyToken, | ||
| want: false, | ||
| }, | ||
| { | ||
| name: "empty string", | ||
| strategy: "", | ||
| want: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| got := IsDoclingChunkingStrategy(tt.strategy) | ||
| if got != tt.want { | ||
| t.Errorf("IsDoclingChunkingStrategy(%q) = %v, want %v", tt.strategy, got, tt.want) | ||
| } | ||
| }) | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add validations such that if these are specified then DocumentProcessorConfig is not set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Added
ValidateSpec()onUnstructuredDataProductSpecthat returns an error when a Docling chunking strategy is selected andDocumentProcessorConfigis set. Wired it up early in theReconcile()loop so invalid specs are rejected before any CRs are created. Also changedDocumentProcessorConfigto a pointer so the nil check is clean.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be done via validating webhook but it's understandable that it's not configured right now for this controller ... have you evaluated doing this via kubebuilder's inbuilt CRD validation - https://book.kubebuilder.io/reference/markers/crd-validation.html
i am suggesting this approach because i want the end result that the CR is not even applied and is rejected at creation time rather than getting accepted and then causes a runtime failure
what you've implemented is like an API request is accepted and fails at runtime ... what i want is that the API requested is rejected if it's incorrect