[RHIDP-11653] Include Lightspeed By Default#202
[RHIDP-11653] Include Lightspeed By Default#202Jdubrick wants to merge 12 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
… scripts Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
…ault Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Code Review by Qodo
1. rag-init shell command broken
|
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Review Summary by QodoInclude Lightspeed by default in RHDH Local
WalkthroughsDescription• Moves Lightspeed to default compose.yaml, enabling it by default • Consolidates Lightspeed configs from developer-lightspeed to root /configs • Disables FAB plugin due to conflict with Lightspeed FAB • Splits Lightspeed documentation into user and maintainer guides • Updates CI tests to remove dedicated Lightspeed compose test Diagramflowchart LR
A["developer-lightspeed/<br/>directory structure"] -->|"consolidate configs"| B["configs/extra-files/<br/>lightspeed files"]
C["developer-lightspeed/<br/>compose.yaml"] -->|"merge into"| D["compose.yaml<br/>default services"]
E["developer-lightspeed/<br/>README.md"] -->|"split into"| F["docs/lightspeed/<br/>working-with-lightspeed.md"]
E -->|"split into"| G["docs/lightspeed/<br/>maintaining-lightspeed.md"]
H["start/stop scripts"] -->|"remove"| I["use standard<br/>compose commands"]
J["FAB plugin"] -->|"disable"| K["avoid conflict<br/>with Lightspeed FAB"]
File Changes1. developer-lightspeed/scripts/start-lightspeed.sh
|
rhdh-qodo-merge
Bot
added
documentation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
|
Comment about rag init is not the case, functioning as expected. |
|
IIRC UI team had an interest in the FAB pieces, previously we set it aside to merge the PR |
|
/cc @karthikjeeyar |
karthikjeeyar
left a comment
karthikjeeyar
left a comment
There was a problem hiding this comment.
Verified locally! Changes looks good to me. I have one small request to include notebook configuration.
|
Even though it works, I have noticed this double slash in the embedding_model |
@karthikjeeyar That unfortunately has to be there, the way Llama Stack references the embedding model since its mounted locally and not remote needs that for the pathing :/ |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
|
@karthikjeeyar I updated the config for notebooks. I think tests are failing because of changes to the default plugins (non lightspeed) @JslYoon can you confirm the config I added? |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
|
| pluginConfig: | ||
| dynamicPlugins: | ||
| frontend: | ||
| red-hat-developer-hub.backstage-plugin-lightspeed: | ||
| translationResources: | ||
| - importName: lightspeedTranslations | ||
| module: Alpha | ||
| ref: lightspeedTranslationRef | ||
| dynamicRoutes: | ||
| - path: /lightspeed | ||
| importName: LightspeedPage | ||
| mountPoints: | ||
| - mountPoint: application/listener | ||
| importName: LightspeedFAB | ||
| - mountPoint: application/provider | ||
| importName: LightspeedDrawerProvider | ||
| - mountPoint: application/internal/drawer-state | ||
| importName: LightspeedDrawerStateExposer | ||
| config: | ||
| id: lightspeed | ||
| - mountPoint: application/internal/drawer-content | ||
| importName: LightspeedChatContainer | ||
| config: | ||
| id: lightspeed | ||
| priority: 100 |
There was a problem hiding this comment.
| pluginConfig: | |
| dynamicPlugins: | |
| frontend: | |
| red-hat-developer-hub.backstage-plugin-lightspeed: | |
| translationResources: | |
| - importName: lightspeedTranslations | |
| module: Alpha | |
| ref: lightspeedTranslationRef | |
| dynamicRoutes: | |
| - path: /lightspeed | |
| importName: LightspeedPage | |
| mountPoints: | |
| - mountPoint: application/listener | |
| importName: LightspeedFAB | |
| - mountPoint: application/provider | |
| importName: LightspeedDrawerProvider | |
| - mountPoint: application/internal/drawer-state | |
| importName: LightspeedDrawerStateExposer | |
| config: | |
| id: lightspeed | |
| - mountPoint: application/internal/drawer-content | |
| importName: LightspeedChatContainer | |
| config: | |
| id: lightspeed | |
| priority: 100 |
Similar comment to redhat-developer/rhdh-operator#2756 (comment)
With {{inherit}}, we should be able to also inherit the pluginConfig from the DPDY. So I think we can further simplify this.. (unless there is a specific difference in the config)
| # Default plugin catalog index image | ||
| # Requires RHDH 1.9+ to be handled. | ||
| CATALOG_INDEX_IMAGE=quay.io/rhdh/plugin-catalog-index:1.9 | ||
| CATALOG_INDEX_IMAGE=quay.io/rhdh/plugin-catalog-index:1.10 |
There was a problem hiding this comment.
Since main should point to a stable GA release of RHDH, this PR should target the release-1.10 branch first (once it is created), and only be cherry-picked to main once 1.10 is out.
/hold
| ## Disabling Lightspeed | ||
|
|
||
| Developer Lightspeed is included by default. If you don't configure an LLM provider, Lightspeed will remain in an unconfigured/dormant state and not affect your RHDH experience. | ||
|
|
||
| To fully remove Lightspeed from your setup: | ||
|
|
||
| 1. **Remove the Lightspeed plugins** from `configs/dynamic-plugins/dynamic-plugins.yaml` (or your `dynamic-plugins.override.yaml` if using one). Delete or comment out the two Lightspeed plugin entries (the frontend and backend packages). | ||
|
|
||
| 2. **Remove the Lightspeed services** from `compose.yaml`. Delete or comment out the `rag-init` and `lightspeed-core` service blocks, and the `rag_embeddings` and `rag_vector_db` volume declarations. | ||
|
|
||
| 3. **Remove the Lightspeed configuration** from `configs/app-config/app-config.yaml`. Delete or comment out the `lightspeed:` section at the bottom of the file. |
There was a problem hiding this comment.
We strive to avoid making users modify version-controlled files. Otherwise they might run into conflicts when pulling the latest changes.
To make the opt-out experience seamless, I'd suggest taking a look at Compose profiles and/or an env-var-driven approach (or any other approach that doesn't require modifying any version-controlled files).
There was a problem hiding this comment.
Might make sense to render these 2 docs files as techdocs in the running RHDH instance, I think.
| # - package: 'oci://quay.io/rhdh/red-hat-developer-hub-backstage-plugin-global-floating-action-button:{{inherit}}' | ||
| - package: ./dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-global-floating-action-button | ||
| disabled: false | ||
| disabled: true # disabled as conflicts with Lightspeed FAB |
There was a problem hiding this comment.
It conflicts with Lightspeed FAB, but is this re-enabled if users disable Lightspeed ?
|
@rm3l marking this as a draft to make the changes you suggested as well as wait for the 1.10 release, since we need the catalog index updated to take advantage of the |
5 participants
Description
compose.yaml/configs/developer-lightspeeddirectory{{inherit}}for lightspeed plugin1.10to include lightspeed. Also resolves CI errors for other default pluginsWhich issue(s) does this PR fix or relate to
https://redhat.atlassian.net/browse/RHIDP-11653
https://redhat.atlassian.net/browse/RHIDP-11654
PR acceptance criteria
How to test changes / Special notes to the reviewer