docs: fix lock file deadlock documentation for dynamic plugins cache#5026
Open
Fortune-Ndlovu wants to merge 5 commits into
Open
docs: fix lock file deadlock documentation for dynamic plugins cache#5026Fortune-Ndlovu wants to merge 5 commits into
Fortune-Ndlovu wants to merge 5 commits into
Conversation
- Fix wrong lock file name in rm command (RHDHBUGS-450) - Document 10-min timeout and CrashLoopBackOff behavior - Add DYNAMIC_PLUGINS_LOCK_TIMEOUT_MS env var - Clarify lock only applies with persistent volumes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5026 +/- ##
==========================================
- Coverage 55.39% 54.77% -0.62%
==========================================
Files 122 110 -12
Lines 2365 2147 -218
Branches 562 536 -26
==========================================
- Hits 1310 1176 -134
+ Misses 1048 969 -79
+ Partials 7 2 -5
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
rm3l
reviewed
Jul 1, 2026
Remove incorrect CrashLoopBackOff claim. The exit handler auto-cleans the stale lock on shutdown so the pod self-heals after one timeout cycle. Reframe manual rm as optional shortcut. Add note that 1.10.x and earlier had no timeout (Python script, infinite wait). Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
Contributor
|
The container image build workflow finished with status: |
rm3l
reviewed
Jul 2, 2026
…tent volume Address review feedback: the lock file is created unconditionally by the init container, not only when a persistent volume is used. Lock contention is what requires a shared persistent volume. Also fix Note formatting consistency. Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
Drop the RHDH 1.10.x historical note and the persistent volume note (already covered in the intro paragraph). Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
Contributor
|
The container image build workflow finished with status: |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dynamic-plugins.lock→install-dynamic-plugins.lock, matching types.ts#L78)DYNAMIC_PLUGINS_LOCK_TIMEOUT_MSenvironment variable documentationRelates-to: RHDHBUGS-450
Test plan
install-dynamic-plugins.lock)