Revert "Use yaml package for formatting"#1240
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Apr 29, 2026
Merged
Revert "Use yaml package for formatting"#1240datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
This reverts commit 22d01b4. There were many bugs in the new formatter implementation, so we're reverting for now. In order to move forwards with this, we'll either need to adjust the behaviour of `toString` in the YAML parser through contributing patches, or write our own formatter. Fixes redhat-developer/vscode-yaml#1237 Fixes redhat-developer/vscode-yaml#1235 Fixes redhat-developer/vscode-yaml#1234 Fixes redhat-developer/vscode-yaml#1233 Fixes redhat-developer#1237
datho7561
force-pushed
the
revert-formatter-changes
branch
from
499b0b7 to
12cb58a
Compare
|
For an extra data point, |
This was referenced Apr 30, 2026
datho7561
added a commit
that referenced
this pull request
May 1, 2026
See #1240 (comment) See redhat-developer/vscode-yaml#1241 Signed-off-by: David Thompson <davthomp@redhat.com>
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 22d01b4.
There were many bugs in the new formatter implementation, so we're reverting for now.
In order to move forwards with this, we'll either need to adjust the behaviour of
toStringin the YAML parser through contributing patches, or write our own formatter.What issues does this PR fix or reference?
proseWrap: “preserve”is ignored, and text is always auto wrapped since v1.22.0 vscode-yaml#1234Is it tested? How?
Existing tests