Skip to content

Add tests for bugs in reverted formatter changes#1241

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:tests-for-formatter
Apr 30, 2026
Merged

Add tests for bugs in reverted formatter changes#1241
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:tests-for-formatter

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Readd the fix that doesn't return any text edits if the formatter changes nothing
  • Add a bunch of tests for the cases where the new formatter was failing

What issues does this PR fix or reference?

N/A

Is it tested? How?

Unit tests of the formatter

- Readd the fix that doesn't return any text edits if the formatter
  changes nothing
- Add a bunch of tests for the cases where the new formatter was failing

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the tests-for-formatter branch from a24e1cc to 45d5bf5 Compare April 29, 2026 22:15
@datho7561 datho7561 changed the title [WIP] Add tests for bugs in reverted formatter changes Add tests for bugs in reverted formatter changes Apr 29, 2026
@datho7561 datho7561 marked this pull request as ready for review April 29, 2026 22:15
@datho7561 datho7561 moved this to Pending review in Java Tooling Apr 29, 2026
@datho7561 datho7561 requested a review from shin19991207 April 29, 2026 22:18
Copy link
Copy Markdown
Member

@shin19991207 shin19991207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, David!

@datho7561 datho7561 added this to the 1.23.0 milestone Apr 30, 2026
@datho7561 datho7561 added the bug label Apr 30, 2026
@datho7561 datho7561 merged commit af6fabb into redhat-developer:main Apr 30, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Pending review to Done in Java Tooling Apr 30, 2026
@datho7561 datho7561 deleted the tests-for-formatter branch April 30, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants