Support disabling schema source URI in hovers#1242
Merged
datho7561 merged 3 commits intoredhat-developer:mainfrom Apr 30, 2026
Merged
Support disabling schema source URI in hovers#1242datho7561 merged 3 commits intoredhat-developer:mainfrom
datho7561 merged 3 commits intoredhat-developer:mainfrom
Conversation
datho7561
requested changes
Apr 30, 2026
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Seems to be working well, just think the name could be better.
You might want to create a PR in vscode-yaml in order to register the setting there so it shows up in the settings page. As a convention, when we add new settings, we generally open a PR with the setting registered on the client side at the same time.
Member
Author
|
Created a PR in vscode-yaml to register the setting: redhat-developer/vscode-yaml#1238 |
datho7561
approved these changes
Apr 30, 2026
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Morgan!
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added the
yaml.hoverSchemaSourceconfiguration option to control whether the schema source is shown in hover tooltips. Defaults totrue.What issues does this PR fix or reference?
Fixes #1120
Is it tested? How?