Skip to content

pin gofumpt to a version, so ci deterministic#127

Merged
acornett21 merged 1 commit into
redhat-openshift-ecosystem:mainfrom
acornett21:fix_make_fmt
May 4, 2026
Merged

pin gofumpt to a version, so ci deterministic#127
acornett21 merged 1 commit into
redhat-openshift-ecosystem:mainfrom
acornett21:fix_make_fmt

Conversation

@acornett21
Copy link
Copy Markdown
Contributor

@acornett21 acornett21 commented May 4, 2026

Summary by CodeRabbit

  • Chores

    • Pinned a development tool version for consistent build behavior.
  • Style

    • Reformatted internal code for improved maintainability.

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@openshift-ci openshift-ci Bot requested review from bcrochet and komish May 4, 2026 16:43
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 74a77fa4-3bef-4172-998a-9ba04e1a356b

📥 Commits

Reviewing files that changed from the base of the PR and between a54d794 and 48c86aa.

📒 Files selected for processing (2)
  • Makefile
  • internal/prowjob.go

Walkthrough

The pull request introduces two independent, minor changes: pinning the gofumpt tool to version v0.10.0 in the Makefile, and reformatting a multi-line fmt.Sprintf call in internal/prowjob.go without functional impact.

Changes

Tooling and Code Formatting

Layer / File(s) Summary
Tool Version Pinning
Makefile
Adds GOFUMPT_VERSION ?= v0.10.0 variable and updates the gofumpt target to use the pinned version instead of @latest.
Code Formatting
internal/prowjob.go
Reformats the return fmt.Sprintf(...) statement in getJobArtifactsURL to multi-line style; format string and arguments remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: pinning gofumpt to a specific version to ensure CI determinism, which matches the Makefile changes that introduce GOFUMPT_VERSION variable.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test files were modified in this PR, making this check not applicable.
Test Structure And Quality ✅ Passed PR modifies Makefile and internal/prowjob.go only; no Ginkgo test files are changed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@acornett21 acornett21 merged commit b0ec19a into redhat-openshift-ecosystem:main May 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant