Upgrade Font Awesome Free 5.15.4 -> 7.2.0#467
Open
fidergo-stephane-gourichon wants to merge 1 commit into
Open
Upgrade Font Awesome Free 5.15.4 -> 7.2.0#467fidergo-stephane-gourichon wants to merge 1 commit into
fidergo-stephane-gourichon wants to merge 1 commit into
Conversation
FA7 ships woff2 only (drops eot, svg, ttf, woff); backward-compatible @font-face aliases for "Font Awesome 5" names are included in the CSS, so existing fas/far/fab icon class references continue to work. Sources: - https://github.com/FortAwesome/Font-Awesome/releases - https://unpkg.com/@fortawesome/fontawesome-free@7.2.0/css/all.css - https://unpkg.com/@fortawesome/fontawesome-free@7.2.0/css/all.min.css - https://unpkg.com/@fortawesome/fontawesome-free@7.2.0/webfonts/fa-*.woff2
Owner
|
Hey @fidergo-stephane-gourichon, thanks for this PR. From a first check most icons look good. The once I'm not so happy with I will work through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is a little more complicated than the easy ones. FA7 ships woff2 only (drops eot, svg, ttf, woff); backward-compatible @font-face aliases for "Font Awesome 5" names are included in the CSS, so existing fas/far/fab icon class references continue to work.
Sources:
I followed the existing pattern of copying the regular and minified version available from public source.
Perhaps another pattern like in 3869aa6 would make easier to review.