test(hybrid): exercise FilterExpression form of vsimFilter in integration#33
Open
banker wants to merge 1 commit into
Open
test(hybrid): exercise FilterExpression form of vsimFilter in integration#33banker wants to merge 1 commit into
banker wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing integration coverage for the FilterExpression (typed filter DSL) form of HybridQuery.vsimFilter by driving FT.HYBRID against a real Redis 8.4+ instance, closing the final acceptance criterion from #20.
Changes:
- Imports the typed filter DSL helpers (
Tag,Num) into the hybrid integration test suite. - Adds an integration test verifying
vsimFilteraccepts a composedFilterExpressionand correctly gates VSIM-side candidates (using the existing “gibberish text” isolation strategy).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #20. The type widening (
vsimFilter: string | FilterExpression), therenderFilter()plumbing, the unit-test coverage of both forms, and the docs update all landed during PR #9's review cycle. This PR fills the last remaining acceptance criterion from the issue: an integration test that drives the typed DSL form throughFT.HYBRIDagainst a real Redis 8.4+ container.vsimFilter (pre-filter on vector candidates)describe block.Tag('category').eq('furniture').and(Num('price').lt(400))to confirm DSL composition renders correctly to Redis's filter dialect.vsimFilterbehavior.Test plan
npm run type-check:tests— cleannpx vitest run tests/integration/hybrid-search.test.ts— 9/9 passing (8 pre-existing + 1 new)🤖 Generated with Claude Code