defensive code when parsing FT.SEARCH results#463
Merged
Conversation
- do not assume results array is non-empty - simplify and verify score/content/payload permutations
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #448
The biggest "fix" is the second one; in the existing code, a mismatch in the setup code (that calculates the elements-per-row) and the actual reading code meant that the "with payloads, without content" scenario applied different logic in the two places (nested
ifin the init, but independentifin the parser), with unpredictable results. This has been simplified.Note
Medium Risk
Changes core
FT.SEARCHresponse parsing logic; incorrect stride/offset handling could corrupt document parsing for certainWITHSCORES/WITHPAYLOADS/NOCONTENTcombinations, though new tests reduce regression risk.Overview
Hardens
FT.SEARCHresult parsing inSearchResultby guarding against unexpected empty responses and by replacing the previous offset/step calculation with a singlestride+ sequentialoffsetreader that stays consistent acrossWITHSCORES,WITHPAYLOADS, andNOCONTENTpermutations.Expands test coverage to run query-parameter search tests across all 8 combinations of scores/payloads/content, and adds assertions that payloads and returned fields are present/absent as requested.
Written by Cursor Bugbot for commit 42e33a3. This will update automatically on new commits. Configure here.