Conversation
2. support JSON.SET FPHA, with tests to validate round-trip the shipped/unshipped had been jumbled, so have been reset; the only delta is the FPHA overloads
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
atakavci
approved these changes
Mar 31, 2026
Comment on lines
+25
to
+32
| [Browsable(false), EditorBrowsable(EditorBrowsableState.Never)] | ||
| public bool Set(RedisKey key, RedisValue path, object obj, When when, JsonSerializerOptions? serializerOptions) | ||
| => Set(key, path, JsonSerializer.Serialize(obj, serializerOptions), when, JsonNumericArrayStorage.NotSpecified); | ||
|
|
||
| /// <inheritdoc/> | ||
| [Browsable(false), EditorBrowsable(EditorBrowsableState.Never)] | ||
| public bool Set(RedisKey key, RedisValue path, RedisValue json, When when) | ||
| => Set(key, path, json, when, JsonNumericArrayStorage.NotSpecified); |
Collaborator
There was a problem hiding this comment.
we will keep these until major release, right ?
how about marking them obsolete (also as reminder) here and in async as well?
Collaborator
Author
There was a problem hiding this comment.
It isn't a good idea to mark them obsolete, as that will cause unnecessary build warnings/failures (depending on build settings) when the exact combination is specified; I try to avoid drama if at all possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Experimental]the shipped/unshipped had been jumbled, so have been reset; the only delta is the FPHA overloads
Note
Medium Risk
Expands the public API surface (new
JsonNumericArrayStorageand newSet/SetAsyncoverloads) and changes howJSON.SETarguments are constructed, which could affect compatibility with different RedisJSON versions.Overview
Adds
JsonNumericArrayStorageand extendsJSON.SET(JsonCommandBuilder.Set,JsonCommands.Set,JsonCommandsAsync.SetAsync) to optionally emit theFPHAmodifier for numeric array storage (BF16/FP16/FP32/FP64), while hiding legacy overloads to steer callers to the explicit option.Removes
[Experimental]markers (and theNRS001warning suppression) from previously gated 8.4 Search/Vector/Hybrid APIs and updatesPublicAPI.Shipped/Unshippedaccordingly, plus adds JSON round-trip tests validatingFPHAbehavior (skipped unless Redis >= 8.8).Written by Cursor Bugbot for commit bffcef8. This will update automatically on new commits. Configure here.