Adding an hmget test with more fields and smaller values (so that it becomes listpack) #358
Open
slice4e wants to merge 5 commits into
Open
Adding an hmget test with more fields and smaller values (so that it becomes listpack) #358slice4e wants to merge 5 commits into
slice4e wants to merge 5 commits into
Conversation
| @@ -0,0 +1,94 @@ | |||
| version: 0.4 | |||
| name: memtier_benchmark-session-caching-hash-100k-sessions-with-hfe-expired-fields-hkeys | |||
There was a problem hiding this comment.
Test name missing "playbook-" prefix, mismatches filename
Medium Severity
The name field is memtier_benchmark-session-caching-hash-... but the filename includes playbook- (memtier_benchmark-playbook-session-caching-hash-...). Every other playbook file in the repo has the name field match the filename exactly (minus .yml), including the playbook- segment. Since name is used as the test_name identifier in stats, comparisons, and Parca agent labels, this mismatch breaks the established naming convention and could cause confusion in benchmark reporting and cross-referencing.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Runs memtier_benchmark, for a keyspace length of 1M keys pre-loading
listpack-encoded HASHes with 100 fields and 32 Byte values. After
pre-loading, issues HMGET requesting all 100 fields. Tests HMGET
performance on listpack-encoded hashes where N == L.
Adding this test, in relation to this PR: redis/redis#14903
Note
Low Risk
Low risk: adds new benchmark suite YAMLs only, with no production code changes; main risk is increased benchmark runtime/resource usage or misconfigured workloads.
Overview
Adds a new memtier benchmark suite to measure
HMGETon listpack-encoded hashes by preloading 1M keys with 100 fields of 32B values and reading all 100 fields with--pipeline 1.Adds two session-caching playbook suites that preload 100k
session:*hashes and apply hash-field expiration viaHPEXPIRE, then benchmark read performance forHGETALLand a siblingHKEYSvariant designed to highlight CPU-side optimizations under many expired fields.Written by Cursor Bugbot for commit 8954c76. This will update automatically on new commits. Configure here.