fix(test-suites): add missing --pipeline 10 to mget-1KiB-5keys-pipeline-10 (v0.3.18)#394
Open
paulorsousa wants to merge 1 commit into
Conversation
…ne-10 The clientconfig.arguments for `memtier_benchmark-5Mkeys-string-mget-1KiB-5keys-pipeline-10` was missing the `--pipeline 10` flag (sibling specs at other value sizes — 100B, 512B — all carry it). Without the flag, memtier_benchmark defaulted to pipeline=1, so the test was not exercising the pipelined-MGET path its name advertises. This made the run produced for redis/redis#14907 misleading: the −12.6 % "regression" on this spec was at effective pipeline=1, while every other pipeline-10 MGET sibling on the same matrix showed +1–7 % wins under proper pipelining. Bump to 0.3.18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memtier_benchmark-5Mkeys-string-mget-1KiB-5keys-pipeline-10.ymlwas missing--pipeline 10in itsclientconfig.arguments. Every sibling pipeline-10 MGET spec on the same matrix (100B, 512B, 1KiB-* with various key counts) ships the flag — this one was the only outlier.Without the flag, memtier_benchmark defaults to pipeline=1, so the test was running un-pipelined despite the name advertising pipeline-10.
Why it matters
A recent regression-investigation run on redis/redis#14907 (per-IO-thread stat counters) flagged
mget-1KiB-5keys-pipeline-10as the only σ-confirmed regression in the io-threads=8 string suite (−12.6 %). Every other pipeline-10 MGET sibling on the same axis (+1.5 % to +6.5 %) moved the opposite direction, which didn't fit any false-sharing-fix mechanism. Spec inspection showed the--pipeline 10was missing — the regression was being measured at effective pipeline=1.Changes
--pipeline 10to theclientconfig.argumentsline.Test plan
mget-1KiB-5keys-pipeline-10against PR head + unstable baseline onoss-standalone-08-io-threads; confirm both numbers shift up to the pipelined operating point and the PR delta no longer shows the spurious −12 %.Note
Low Risk
Low risk: updates a benchmark spec flag and bumps package version; main impact is changing how one benchmark workload is executed and thus its reported results.
Overview
Fixes a benchmark spec mismatch by adding the missing
--pipeline 10tomemtier_benchmark-5Mkeys-string-mget-1KiB-5keys-pipeline-10.yml, ensuring the workload actually runs with pipeline depth 10 as named.Also bumps the package version in
pyproject.tomlfrom0.3.17to0.3.18.Reviewed by Cursor Bugbot for commit ef853ba. Bugbot is set up for automated code reviews on this repo. Configure here.