Add near-max listpack ZINCRBY coverage (1M keys × 120 members × 50B)#417
Open
fcostaoliveira wants to merge 1 commit into
Open
Add near-max listpack ZINCRBY coverage (1M keys × 120 members × 50B)#417fcostaoliveira wants to merge 1 commit into
fcostaoliveira wants to merge 1 commit into
Conversation
The existing 16-element listpack ZINCRBY spec is too small to exercise the near-max-listpack lpFind/traversal path (120 members, just below zset-max-listpack-entries 128). Adds coverage for the regime reported in redis/redis#15288.
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ZINCRBY benchmark for sorted sets at near-max listpack size — 1,000,000 keys, each with 120 members of 50-byte strings (just below
zset-max-listpack-entries128 andzset-max-listpack-value64). ZINCRBY repeatedly increments one fixed member, forcing an almost-full listpack traversal on every call.The existing 16-element listpack ZINCRBY spec is too small to exercise this path. This near-max variant closes a coverage gap relevant to redis/redis#15288.
Validated with
redis-benchmarks-spec-cli --tool stats --fail-on-required-diff(passes).Note
Cursor Bugbot is generating a summary for commit c1c3bf0. Configure here.