Add small-keyspace MSET overwrite coverage (100 hot keys, 10B values)#418
Open
fcostaoliveira wants to merge 1 commit into
Open
Add small-keyspace MSET overwrite coverage (100 hot keys, 10B values)#418fcostaoliveira wants to merge 1 commit into
fcostaoliveira wants to merge 1 commit into
Conversation
Existing MSET specs load 1M-10M distinct keys (DRAM-latency dominated). This adds a cache-resident, low-collision regime (100 keys, ~11-byte names) that keeps dictFind L1/L2-bound, to surface dict fast-path p50 effects per redis/redis#15320.
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an MSET benchmark over a tiny, cache-resident keyspace — 100 string keys (~11-byte names) repeatedly overwritten with MSET (3 pairs/command), 10-byte EMBSTR values, pipeline 10.
Existing MSET specs load 1M–10M distinct keys and are DRAM-latency dominated. This adds a low-collision, L1/L2-resident regime so dictFind fast-path effects on p50 latency are observable — the regime in redis/redis#15320.
Validated with
redis-benchmarks-spec-cli --tool stats --fail-on-required-diff(passes).Note
Cursor Bugbot is generating a summary for commit eb52db1. Configure here.