Fix hiredis readiness checks for high file descriptors#4115
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
vladvildanov
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes hiredis connection readiness checks for applications that can have socket file descriptors above
FD_SETSIZE. The previous implementation usedselect.select(), which can raiseValueError: filedescriptor out of range in select()on high-numbered descriptors.The readiness probe now uses
selectors.DefaultSelector()instead. This lets Python choose the best platform selector, such asepoll,kqueue, orpoll, while preserving the important behavior from #4063:can_read()remains non-destructive and does not read from the socket or consume hiredis parser state.Tests were added to verify that the helper uses the default selector and can handle a real high-numbered file descriptor.
Fixes: #4113
Note
Low Risk
Narrow change to hiredis sync polling only, with new tests; behavior is intended to match prior non-destructive readiness checks on supported platforms.
Overview
Fixes hiredis sync connection readiness checks when Redis sockets use file descriptors above
FD_SETSIZE, which could raiseValueError: filedescriptor out of range in select()._socket_can_readinredis/_parsers/hiredis.pyno longer usesselect.select(); it usesselectors.DefaultSelector()(epoll/kqueue/poll where available) for the same non-destructive probe. SSLpending()short-circuit is unchanged, socan_read()still does not read from the socket or consume hiredis parser state.Tests assert the helper registers for
EVENT_READvia the default selector and that a high-numbered fd (viafcntldup) can be polled without error when the platform default is notSelectSelector.Reviewed by Cursor Bugbot for commit 778d244. Bugbot is set up for automated code reviews on this repo. Configure here.