desc.bitsPerPixelOrBlock is now set to ddspf.RGBBitCount for uncompre…#9
Open
leobenaducci wants to merge 1 commit intoredorav:masterfrom
Open
desc.bitsPerPixelOrBlock is now set to ddspf.RGBBitCount for uncompre…#9leobenaducci wants to merge 1 commit intoredorav:masterfrom
leobenaducci wants to merge 1 commit intoredorav:masterfrom
Conversation
Owner
|
Hey thanks for the PR, I'm not sure why this needed changing, could you explain what issues you were having? The function bits per pixel or block already takes uncompressed formats into account |
Author
|
Hi, the problem is that in some cases the pitch and the full image size is not correct, 24-bit RGB files format is set to B8G8R8X8_UNORM, same as some 32-bit when ddspf.flags & DDS_RGB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ssed formats