Conversation
rockwotj
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for distributed tracing via OpenTelemetry into the runtime and agent components. Key changes include:
- Adding new tracing messages (TraceContext, Trace, Span) in both Proto and Python type stubs.
- Integrating OpenTelemetry in the gRPC and runtime layers to propagate and collect trace spans.
- Removing the obsolete RPKMCPEndpoint and updating dependencies accordingly.
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/redpanda/runtime/proto/runtime_pb2.pyi | Added new tracing message classes and fields to support OpenTelemetry. |
| src/redpanda/runtime/proto/runtime_pb2.py | Updated descriptors to include new tracing messages and options. |
| src/redpanda/runtime/_otel.py | Introduced helper functions to convert and collect spans via OpenTelemetry. |
| src/redpanda/runtime/_grpc.py | Enhanced RuntimeServer to extract trace context and wrap agent invocation in tracing spans. |
| src/redpanda/runtime/init.py | Added _TracingSSEMCPEndpoint to inject tracing headers for endpoints. |
| src/redpanda/agents/_mcp.py | Removed the now-unused RPKMCPEndpoint. |
| src/redpanda/agents/init.py | Updated exports to no longer include RPKMCPEndpoint. |
| pyproject.toml | Added OpenTelemetry and types-protobuf dependencies. |
| proto/redpanda/runtime/proto/runtime.proto | Defined new tracing messages to mirror the changes in Python. |
| examples/stream_agent/* | Updated examples to work with the new tracing implementations. |
| Taskfile.yaml | Minor adjustments in protobuf include paths. |
Files not reviewed (2)
- examples/stream_agent/.gitignore: Language not supported
- examples/stream_agent/.python-version: Language not supported
For the LLM calls and the tool calls
garrett-raska
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.