Build skipList before exclude enrichment in apply section#437
Open
tifennlegoff wants to merge 1 commit into
Open
Build skipList before exclude enrichment in apply section#437tifennlegoff wants to merge 1 commit into
tifennlegoff wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is related with this issue)
Currently have an issue, all enrichments listed in
applymeta are not replayed. We added this processor to replay all enrichment, even skipped ones because, some of them can be skipped because of a dependencies issue with the failed one. We added this processor before the workflow:Our workflow looks like that
But, in the document resulted, the enrichments listed in
applyare not replayed, only the one previously infailedis replayed. They are not listed insucceeded, they are inskippedand the field added by enrichment are not present.I'm not expert in Go but in my PR, if I well understand, in function skipFromMeta, the
if skippedsection should be before theif applyone because theif applywill remove the enrichment from the listskipListfilled by theif skippedsection.I wrote test to validate if we have the expected result and it's works 🍾
I run tests for others functions
TestWorkflows,TestWorkflowsDeps,TestWorkflowsParallelandTestWorkflowsWithOrderResourcesI run workflow tests
TestWorkflows,TestWorkflowsDeps,TestWorkflowsParallelandTestWorkflowsWithOrderResources