Add global --ca-cert and persist connection options in alias add#189
Open
Add global --ca-cert and persist connection options in alias add#189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #188
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What was changed?
--ca-cert <path>CLI option and propagated explicit global-option override metadata throughCliContext.alias add:ignore_ssl,timeout,parallel, andca_cert(with backward-compatible defaults for existing configs).resolve_connection_optionsto merge alias defaults with global CLI overrides.verify_ssl,timeout, CA certificate file).cpandrmquery parameter parsing to reuse alias-specific timeout/parallel defaults from source aliases.Related issues
Does this PR introduce a breaking change?
No.
Other information:
Validated with:
cargo fmtcargo test test_add_alias_persists_connection_options -- --nocapturecargo test test_resolve_connection_options_from_alias -- --nocapturecargo test test_resolve_connection_options_cli_override -- --nocapturecargo test parse_with_alias_defaults -- --nocapturecargo test(integration-style tests that require a running ReductStore onlocalhost:8383fail with connection errors when the service is not running)