Skip to content

Add global --ca-cert and persist connection options in alias add#189

Open
atimin wants to merge 3 commits intomainfrom
188-feature-add-global---ca-cert-and-persist-connection-options-in-alias-add
Open

Add global --ca-cert and persist connection options in alias add#189
atimin wants to merge 3 commits intomainfrom
188-feature-add-global---ca-cert-and-persist-connection-options-in-alias-add

Conversation

@atimin
Copy link
Member

@atimin atimin commented Mar 13, 2026

Closes #188

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What was changed?

  • Added global --ca-cert <path> CLI option and propagated explicit global-option override metadata through CliContext.
  • Extended alias config schema to persist connection options in alias add: ignore_ssl, timeout, parallel, and ca_cert (with backward-compatible defaults for existing configs).
  • Added resolve_connection_options to merge alias defaults with global CLI overrides.
  • Applied resolved options to client creation (verify_ssl, timeout, CA certificate file).
  • Updated cp and rm query parameter parsing to reuse alias-specific timeout/parallel defaults from source aliases.
  • Added tests for:
    • persisting alias connection options,
    • resolving alias/default override precedence,
    • applying alias timeout/parallel defaults in query parsing.

Related issues

Does this PR introduce a breaking change?

No.

Other information:

Validated with:

  • cargo fmt
  • cargo test test_add_alias_persists_connection_options -- --nocapture
  • cargo test test_resolve_connection_options_from_alias -- --nocapture
  • cargo test test_resolve_connection_options_cli_override -- --nocapture
  • cargo test parse_with_alias_defaults -- --nocapture
  • cargo test (integration-style tests that require a running ReductStore on localhost:8383 fail with connection errors when the service is not running)

@atimin atimin requested a review from a team March 13, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add global --ca-cert and persist connection options in alias add

1 participant