Skip to content

143 support for entry attachments#171

Merged
atimin merged 12 commits intomainfrom
143-support-for-entry-attachments
Mar 10, 2026
Merged

143 support for entry attachments#171
atimin merged 12 commits intomainfrom
143-support-for-entry-attachments

Conversation

@AnthonyCvn
Copy link
Member

@AnthonyCvn AnthonyCvn commented Mar 6, 2026

Closes #143

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What was changed?

Support for entry attachments with a dedicated UI for viewing and adding JSON attachments

Related issues

No

Does this PR introduce a breaking change?

No

Other information:

@AnthonyCvn AnthonyCvn linked an issue Mar 6, 2026 that may be closed by this pull request
@AnthonyCvn AnthonyCvn requested a review from atimin March 9, 2026 07:28
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed only one issue. When I use a read-only token, the add-attachment button is available:

Image

we should hide it like we do for other controls.

@AnthonyCvn AnthonyCvn requested review from atimin and removed request for atimin March 10, 2026 10:01
@atimin atimin enabled auto-merge (squash) March 10, 2026 10:14
@atimin atimin merged commit 6bab90d into main Mar 10, 2026
5 checks passed
@atimin atimin deleted the 143-support-for-entry-attachments branch March 10, 2026 10:14
@AnthonyCvn AnthonyCvn restored the 143-support-for-entry-attachments branch March 10, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Entry Attachments

2 participants