fix: add option to disable sync mode#31
Open
Matthiee wants to merge 5 commits intoreearth:mainfrom
Open
Conversation
Member
|
Thank you. Sorry for late reply. I will check your PR. |
rot1024
reviewed
Feb 1, 2024
Member
|
@Matthiee CI fails. Is it OK to ignore this error? |
Author
Hi @rot1024, The goal here would be to have no memory retained hence I put the expected value at 0. However, I was unable to achieve this. I already created this draft PR to demonstrate some ways of reducing the memory when not using the syncing capabilities of the library. There is still I was hoping that you could also have a look to see if maybe there is a better way of doing this or if I'm missing something here. More info on my original issue can be found here #30 Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't fully fix #30 but drastically reduces memory being retained in
QuickJSRuntime.I added 2 test cases to demonstrate this.
Table with memory increases after 100 iterations: