Simplification and fix of the argument parser

[NaddiNadja]

No description provided.

[safl]

Are the CI errors related to this?

[NaddiNadja]

Are the CI errors related to this?

hehe, yes. I'm on it

[coveralls]

Pull Request Test Coverage Report for Build 20331338240

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 29 of 31 (93.55%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 78.633%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/cijoe/cli/cli.py	29	31	93.55%

Totals
Change from base Build 18189340355:	0.2%
Covered Lines:	1583
Relevant Lines:	2077

---

💛 - Coveralls

[safl]

Does this require that one now does not explicitly provide --workflow?
I ask, since there are places where CIJOE is in use where it would like convenient not to have to adjust to that. In other words, could providing --workflow be optional, or does that break with the cleanup done here?

[NaddiNadja]

Does this require that one now does not explicitly provide --workflow?

It did, but I've added it back for backwards compatibility. Also, I have added a bunch of tests for the parse_args() function to support our confidence in it being correct. If there are any cases that you feel like are missing, let me know. Right now I check:

Workflows:

• Giving a workflow as a positional argument
• Giving a workflow as a positional argument with a list of steps
• Giving a workflow with the --workflow argument
• Giving a workflow with the --workflow argument with a list of steps

Scripts:

• Giving a cijoe script (core.example_script_default) as a positional argument
• Giving a cijoe script (core.example_script_default) as a positional argument with script arguments
• Giving a path to a script as a positional argument
• Giving a path to a script as a positional argument with script arguments (should fail)
• Giving a path to a script as a positional argument with a list of steps (should remove steps)

Other:

• Base test for just all arguments to see they are added correctly
• Giving a bunch of arguments in "another order" than the other tests (this was to ensure that e.g. --monitor can be put first)
• Giving no arguments to see that the workflow is set to the default

[safl]

Excellent, thanks!