Skip to content

fix(browser-sdk): lower bulk queue failure logging #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roncohen merged 2 commits into from
Mar 13, 2026
Merged

fix(browser-sdk): lower bulk queue failure logging #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8799e6e
fix(browser-sdk): lower bulk queue failure logging
roncohen Mar 13, 2026
a9cb284
chore: update lockfile for browser SDK version bumps
roncohen Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/browser-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reflag/browser-sdk",
"version": "1.4.6",
"version": "1.4.7",
"packageManager": "yarn@4.1.1",
"license": "MIT",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-sdk/src/bulkQueue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export class BulkQueue {
try {
res = await this.sendBulk(batch);
} catch (error) {
this.logger?.error("bulk request failed; dropping batch", {
this.logger?.debug("bulk request failed; dropping batch", {
error,
batchSize: batch.length,
});
Expand Down Expand Up @@ -190,7 +190,7 @@ export class BulkQueue {
!this.lastDropErrorAt ||
now - this.lastDropErrorAt >= DROP_ERROR_THROTTLE_MS
) {
this.logger?.error("bulk queue dropped events due to max size", {
this.logger?.debug("bulk queue dropped events due to max size", {
droppedEvents: this.droppedSinceLastError,
totalDroppedEvents: this.totalDroppedEvents,
queueSize: this.queue.length + this.getInFlightBatchSize(),
Expand Down
20 changes: 19 additions & 1 deletion packages/browser-sdk/test/bulkQueue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,14 @@ describe("BulkQueue", () => {
await vi.advanceTimersByTimeAsync(10);
expect(sendBulk).toHaveBeenCalledTimes(1);
expect(await queue.size()).toBe(0);
expect(logger.error).toHaveBeenCalledWith(
expect(logger.debug).toHaveBeenCalledWith(
"bulk request failed; dropping batch",
expect.objectContaining({
error: expect.any(Error),
batchSize: 1,
}),
);
expect(logger.error).not.toHaveBeenCalled();
});

it("drops 4xx responses, logs error, and does not retry", async () => {
Expand Down Expand Up @@ -237,9 +238,16 @@ describe("BulkQueue", () => {
resolveSend = resolve;
}),
);
const logger = {
debug: vi.fn(),
info: vi.fn(),
warn: vi.fn(),
error: vi.fn(),
};
const queue = new BulkQueue(sendBulk, {
flushDelayMs: 10_000,
maxSize: 2,
logger,
});

await queue.enqueue(userEvent);
Expand All @@ -249,6 +257,16 @@ describe("BulkQueue", () => {
expect(await queue.size()).toBe(2);
expect(sendBulk).toHaveBeenCalledTimes(1);
expect(sendBulk).toHaveBeenCalledWith([userEvent, companyEvent]);
expect(logger.debug).toHaveBeenCalledWith(
"bulk queue dropped events due to max size",
expect.objectContaining({
droppedEvents: 1,
totalDroppedEvents: 1,
queueSize: 2,
maxSize: 2,
}),
);
expect(logger.error).not.toHaveBeenCalled();

resolveSend?.(new Response("", { status: 200 }));
});
Expand Down
4 changes: 2 additions & 2 deletions packages/openfeature-browser-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reflag/openfeature-browser-provider",
"version": "1.3.4",
"version": "1.3.5",
"packageManager": "yarn@4.1.1",
"license": "MIT",
"repository": {
Expand Down Expand Up @@ -35,7 +35,7 @@
}
},
"dependencies": {
"@reflag/browser-sdk": "1.4.6"
"@reflag/browser-sdk": "1.4.7"
},
"devDependencies": {
"@openfeature/core": "1.5.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reflag/react-sdk",
"version": "1.4.6",
"version": "1.4.7",
"license": "MIT",
"repository": {
"type": "git",
Expand Down Expand Up @@ -37,7 +37,7 @@
}
},
"dependencies": {
"@reflag/browser-sdk": "1.4.6"
"@reflag/browser-sdk": "1.4.7"
},
"peerDependencies": {
"react": "*",
Expand Down
4 changes: 2 additions & 2 deletions packages/vue-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reflag/vue-sdk",
"version": "1.3.4",
"version": "1.3.5",
"license": "MIT",
"repository": {
"type": "git",
Expand Down Expand Up @@ -35,7 +35,7 @@
}
},
"dependencies": {
"@reflag/browser-sdk": "1.4.6"
"@reflag/browser-sdk": "1.4.7"
},
"peerDependencies": {
"vue": "^3.0.0"
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5688,7 +5688,7 @@ __metadata:
languageName: node
linkType: hard

"@reflag/browser-sdk@npm:1.4.6, @reflag/browser-sdk@workspace:packages/browser-sdk":
"@reflag/browser-sdk@npm:1.4.7, @reflag/browser-sdk@workspace:packages/browser-sdk":
version: 0.0.0-use.local
resolution: "@reflag/browser-sdk@workspace:packages/browser-sdk"
dependencies:
Expand Down Expand Up @@ -5829,7 +5829,7 @@ __metadata:
dependencies:
"@openfeature/core": "npm:1.5.0"
"@openfeature/web-sdk": "npm:^1.3.0"
"@reflag/browser-sdk": "npm:1.4.6"
"@reflag/browser-sdk": "npm:1.4.7"
"@reflag/eslint-config": "npm:0.0.2"
"@reflag/tsconfig": "npm:0.0.2"
"@types/node": "npm:^22.12.0"
Expand Down Expand Up @@ -5906,7 +5906,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@reflag/react-sdk@workspace:packages/react-sdk"
dependencies:
"@reflag/browser-sdk": "npm:1.4.6"
"@reflag/browser-sdk": "npm:1.4.7"
"@reflag/eslint-config": "npm:^0.0.2"
"@reflag/tsconfig": "npm:^0.0.2"
"@testing-library/react": "npm:^15.0.7"
Expand Down Expand Up @@ -5966,7 +5966,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@reflag/vue-sdk@workspace:packages/vue-sdk"
dependencies:
"@reflag/browser-sdk": "npm:1.4.6"
"@reflag/browser-sdk": "npm:1.4.7"
"@reflag/eslint-config": "npm:^0.0.2"
"@reflag/tsconfig": "npm:^0.0.2"
"@types/jsdom": "npm:^21.1.6"
Expand Down
Loading