Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/node-sdk-static-fallback-provider.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@reflag/node-sdk": patch
---

Fix `fallbackProviders.static()` so it returns a valid fallback snapshot that `ReflagClient` accepts during fallback initialization.
2 changes: 1 addition & 1 deletion packages/node-sdk/src/flagsFallbackProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ export function createStaticFallbackProvider({
return {
async load() {
return {
version: 0,
version: 1,
savedAt: new Date().toISOString(),
flags: Object.entries(flags).map(([key, isEnabled]) =>
staticFlagApiResponse(key, isEnabled),
Expand Down
38 changes: 37 additions & 1 deletion packages/node-sdk/test/client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
vi,
} from "vitest";

import { BoundReflagClient, ReflagClient } from "../src";
import { BoundReflagClient, fallbackProviders, ReflagClient } from "../src";
import {
API_BASE_URL,
API_TIMEOUT_MS,
Expand Down Expand Up @@ -1194,6 +1194,42 @@ describe("ReflagClient", () => {
}
});

it("should load static fallback flag definitions when live fetch fails", async () => {
httpClient.get.mockResolvedValue({ success: false });

const client = new ReflagClient({
...validOptions,
flagsFallbackProvider: fallbackProviders.static({
flags: {
huddle: true,
"smart-summaries": false,
},
}),
flagsFetchRetries: 0,
});

await client.initialize();

expect(client.getFlag({}, "huddle")).toStrictEqual({
key: "huddle",
isEnabled: true,
config: {
key: undefined,
payload: undefined,
},
track: expect.any(Function),
});
expect(client.getFlag({}, "smart-summaries")).toStrictEqual({
key: "smart-summaries",
isEnabled: false,
config: {
key: undefined,
payload: undefined,
},
track: expect.any(Function),
});
});

it("should log remote flag fetch failures at debug level when using fallback definitions", async () => {
const error = new Error("fetch failed");
const savedAt = "2026-03-09T00:00:00.000Z";
Expand Down
2 changes: 1 addition & 1 deletion packages/node-sdk/test/flagsFallbackProvider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe("flagsFallbackProvider", () => {
});

await expect(provider.load(context)).resolves.toEqual({
version: 0,
version: 1,
savedAt: expect.any(String),
flags: [
{
Expand Down
Loading