Feature/blocker resolution#37
Merged
Merged
Conversation
The `digest` subcommand was renamed to `changelog` during development but README line 157 was never updated, causing a hard error on first run. Co-Authored-By: Paperclip <noreply@paperclip.ing>
The static badge showed 347 passing tests while cargo test --all reports 849+. Static test-count badges rot immediately and signal unmaintained CI discipline. The existing dynamic CI badge (line 7) already communicates build/test health accurately. Closes REF-167 Co-Authored-By: Paperclip <noreply@paperclip.ing>
All 10 performance tests in tests/performance_test.rs now carry #[ignore] so cargo test --all (debug build) skips them, fixing the unreliable CI badge. A dedicated CI step runs them with --release on ubuntu-latest to keep the timing assertions meaningful. Co-Authored-By: Paperclip <noreply@paperclip.ing>
- Add #![allow(dead_code)] to interactive/* modules (TUI refactor in progress) - Add #[allow(clippy::too_many_arguments)] to CLI handler functions - Fix sort_by -> sort_by_key with Reverse across 20+ call sites - Fix max(1).min(8) -> .clamp(1, 8) in indexer and query engine - Fix score.max(0.0).min(1.0) -> .clamp(0.0, 1.0) in evaluator - Fix manual strip_prefix in go.rs, wiki.rs, chat_tui.rs - Fix identical if blocks in query.rs, detection.rs, dependency.rs, site.rs - Fix filter_map -> map in changelog.rs (always returned Some) - Fix manual find loop -> Iterator::find in chat_tui.rs - Fix unwrap after is_some -> Option::filter in trigram.rs (k-way merge) - Fix field assignment outside initializer in indexer.rs tests - Fix unnecessary .is_some() -> .contains_key() in indexer.rs test - Remove always-true assert!(true) in semantic/mod.rs - Add type aliases for complex HashMap types in git_intel.rs and wiki.rs - Add #![allow(dead_code)] to tests/test_helpers.rs - Suppress dead_code for isolated items: build_resolution_cache, should_index, process_event, count_lines, extract_import_path_from_text, Reindexing variant - Enable -D warnings in CI and remove TODO(REF-12) suppression comment Resolves REF-169, closes REF-12. Co-Authored-By: Paperclip <noreply@paperclip.ing>
therecluse26
added a commit
that referenced
this pull request
May 16, 2026
PR #37 was merged with broken CI on Ubuntu, macOS, and Windows runners. Root causes: 1. `*.snap` in .gitignore excluded insta's baseline snapshot files, so CI saw "missing snapshot" failures for 4 pulse::site tests. Insta's convention is the opposite: commit `.snap` (baseline) and ignore `.snap.new` (pending). Replaced the blanket glob with that pair. 2. Windows-only clippy errors under `-D warnings`: - `use crate::output` was unused on Windows (only referenced inside a `#[cfg(unix)]` branch of `check_disk_space`) → gated import on unix. - `root: &Path` parameter of `check_disk_space` was unused on Windows for the same reason → added `cfg_attr(not(unix), allow(unused_variables))`. - `.arg(&path)` in the Windows-specific spawn block triggered `needless_borrows_for_generic_args` → matched the Unix branch's `.arg(path)`. Verified: - `cargo clippy --all-targets -- -D warnings` clean. - `cargo test` — all 855 tests pass (lib 704 + integration 80 + symbol_test 59 + mcp_jsonrpc 6 + doctests 6; 10 perf tests intentionally ignored in debug). - `cargo build --release` clean. Co-Authored-By: Paperclip <noreply@paperclip.ing>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
digestsubcommand was renamed tochangelogduring developmentbut README line 157 was never updated, causing a hard error on first run.
Co-Authored-By: Paperclip noreply@paperclip.ing