Sync with VRCFaceTracking (.NET 10), Async Refactor & Performance Improvements#42
Open
frg2089 wants to merge 4 commits intoregzo2:vrcfacetracking-modulefrom
Open
Sync with VRCFaceTracking (.NET 10), Async Refactor & Performance Improvements#42frg2089 wants to merge 4 commits intoregzo2:vrcfacetracking-modulefrom
frg2089 wants to merge 4 commits intoregzo2:vrcfacetracking-modulefrom
Conversation
Signed-off-by: 舰队的偶像-岛风酱! <frg2089@outlook.com>
…ades - Remove unsafe pointer code, replace with Span<T> and ref instead - Upgrade target framework from hardcoded net7.0 to $(VftTargetFramework) - Apply C# 12 primary constructor syntax in FileBlendshapeScaler - Add Directory.Build.props for CI/CD integration - Update tests to work with new IPicoConnector API (GetBlendShapes returns ReadOnlySpan<float>) - Simplify ConnectorFactory.Build method naming convention - Refactor PacketLogger classes with improved structure - Update dependencies and project references Signed-off-by: 舰队的偶像-岛风酱! <frg2089@outlook.com>
- Include .pdb, .deps.json, and other build artifacts besides the main DLL - Skip copying when running on CI (ContinuousIntegrationBuild=true) Signed-off-by: 舰队的偶像-岛风酱! <frg2089@outlook.com>
- Replace lock-based threading with Task + CancellationToken - Use Socket.ReceiveFromAsync for non-blocking UDP reads - Simplify connection state management with volatile flags Signed-off-by: 舰队的偶像-岛风酱! <frg2089@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR brings major modernization and improvements to the Pico4SAFTExtTrackingModule:
1. Upgrade VRCFaceTracking submodule
Updated the VRCFaceTracking version to 5.4.4.1 (latest on Steam).
2. Modernize codebase with safe C# patterns
Span<T>,ref, andReadOnlySpan<T>.$(VftTargetFramework)to stay in sync with VRCFaceTracking (currently .NET 10).Directory.Build.props.3. Fix build output copying
Copied all output files (.dll, .pdb, .deps.json) to the CustomLibs folder during local builds, not just the main DLL.
4. Refactor LegacyConnector to async/await model
Task+CancellationToken.Socket.ReceiveFromAsyncfor non-blocking UDP reads.IsDisposedmethod.5. Code details & performance optimizations
MemoryMarshal.AsRefto avoid redundant struct copying.