Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new tests to the
dwarffiproject, focusing on correctness, robustness, and coverage of edge cases. The changes include bug fixes in core library logic and the addition of comprehensive tests for backend interaction, bitfield invariants, zero-copy buffer handling, and type normalization.Bug fixes and logic improvements:
_is_acceptableby requiring a non-zero address instead of allowing either a valid address or type info. This tightens the criteria for accepting symbols.get_decoded_constant_databy explicitly checking forNoneand enabling strict validation inbase64.b64decode.New and enhanced test coverage:
Backend and memory interaction:
test_backend_read_write_sizes_and_addressesto verify that backend read and write operations are called with correct addresses and sizes, using a customRecordingBackend.Bitfield and struct invariants:
test_bitfield_preserves_other_bits_across_patternsto ensure that setting bitfields does not affect unrelated bits in the containing struct, across a variety of initial patterns.Zero-copy and buffer handling:
test_zero_copy.pyto confirm that zero-copy views share underlying data correctly and that read-only buffers are properly rejected when writable access is required.Type normalization and packing:
ffi.new.