Skip to content

Update validator tables with a Skip column#32

Open
fgiudici wants to merge 1 commit into
release-engineering:mainfrom
fgiudici:doc-updates
Open

Update validator tables with a Skip column#32
fgiudici wants to merge 1 commit into
release-engineering:mainfrom
fgiudici:doc-updates

Conversation

@fgiudici

@fgiudici fgiudici commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

With PR #27 we introduced a skip rule for some validators based on how much old a version was. Let's add a column to the validators table to start tracking visually which skip rules are applied on each filter.

@fgiudici fgiudici requested a review from a team as a code owner July 7, 2026 13:22
@asergienk

Copy link
Copy Markdown
Collaborator

/fs-retro check and tell me why the review agent workflow is failing, file an issue if needed

@asergienk

Copy link
Copy Markdown
Collaborator

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 7, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:16 PM UTC · Completed 3:20 PM UTC
Commit: eddbd40 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review — approve

Reviewed: docs/VALIDATION_RULES.md (documentation only, +28/−28)

Summary

This PR adds a Skip column to all four validator/filter tables in VALIDATION_RULES.md to visually track which skip rules apply to each validator. The change references the pre-tier-model skip introduced in PR #27.

Verification

I cross-referenced every Skip annotation against the source code in pkg/plcc/validation.go:

  • 10 validators correctly marked pre-tier — these are exactly the validators whose implementation calls isPreTierModel(v): ValidateOCPFormat, ValidateOCPFormatAll, ValidateTierSelected, ValidatePlatformAlignedPhases, ValidatePlatformAlignedOCP, ValidatePlatformAgnosticPhases, ValidatePlatformAgnosticEUSPhases, ValidatePlatformAgnosticEUSOCP, ValidateRollingStreamPhases, ValidateRollingStreamForbiddenPhases.
  • 9 validators correctly left with an empty Skip column — none of them use isPreTierModel(): ValidateIsOperator, ValidateHasVersions, ValidateDatesStatic, ValidateDatesClean, ValidateDatesContiguity, ValidatePhaseEndAfterStart, ValidateVersionNames, ValidateReleaseCadence, ValidateNoDuplicates.
  • FilterIncompletePhases (FBC filter pipeline) correctly has an empty Skip column — it operates on translated FBC output and has no skip logic.

The annotations are fully consistent with the existing prose in the "Pre-tier-model skip" section (lines 62–68) and with the actual code.

Findings

No issues found. The change is a clean, accurate documentation improvement with no behavioral impact.

Previous run

Review — PR #32

Verdict: ✅ Approve

Summary

This is a documentation-only change to docs/VALIDATION_RULES.md. It adds a "Skip" column to four markdown tables (FBC Output Filters, Syntax Validators, Semantic Validators, and Catalog-Level Validators) to visually track which validators apply the pre-tier-model skip rule introduced in PR #27.

Analysis

Correctness — Verified all 20 table entries against the Go source code in pkg/plcc/validation.go. Every validator marked pre-tier in the new column calls isPreTierModel() in its implementation (e.g., ValidateOCPFormat at line 514, ValidateTierSelected at line 497). Every validator with an empty Skip cell does not use isPreTierModel(). The annotations are also 100% consistent with the existing prose description in the "Pre-tier-model skip" section (lines 62–68) of the same document.

Scope — Single documentation file, 28 additions / 28 deletions. No code changes, no behavior changes. The change is well-scoped to the PR description.

Formatting — Markdown table structure is correct: column headers, separator rows, and cell alignment are properly maintained.

No findings.


Labels: PR modifies only documentation (docs/VALIDATION_RULES.md)

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge documentation Improvements or additions to documentation labels Jul 7, 2026
With PR release-engineering#27 we introduced a skip rule for some validators based on how
much old a version was. Let's add a column to the validators table to
start tracking visually which skip rules are applied on each filter.

Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 8, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:33 AM UTC · Completed 9:36 AM UTC
Commit: 7128ea4 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants