fix: distinguish JSON parse errors from validation errors in metadata#264
Merged
Merged
Conversation
… loading Assisted-by: Claude Opus <noreply@anthropic.com>
lubomir
reviewed
Jun 10, 2026
lubomir
left a comment
lubomir
left a comment
Contributor
There was a problem hiding this comment.
The change itself looks good to me, but the lock refresh seems out of place here.
Contributor
Author
|
True, dropping |
lubomir
approved these changes
Jun 10, 2026
lubomir
merged commit 7792110
into
release-engineering:development
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
Compose._load_metadata()singleexcept ValueErrorinto two branches:json.JSONDecodeError("not valid JSON") andValueError/TypeError("not supported by this version of productmd"). Add exception chaining and tests.
Fix: #110