Onboard test coverage to Codecov [RHELDST-40402]#228
Merged
Conversation
4501c2a to
b5675e1
Compare
9dee543 to
aaefa41
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 160 165 +5
=========================================
+ Hits 160 165 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rbikar
requested changes
Jun 25, 2026
| usedevelop=true | ||
| commands= | ||
| pytest --cov-report=term --cov=src/pubtools --cov-fail-under=100 {posargs} | ||
| pytest --cov-report=term --cov-report=xml --cov=src/pubtools {posargs} |
Member
There was a problem hiding this comment.
I believe we can keep --cov-fail-under=100 as the upload to code-cov tends to be flaky, it's better to have check that is dependent on external service.
Update cov testenv to generate coverage.xml report. Adds the codecov action to the coverage workflow in tox-tests.yml. Adds setuptools < 82.0.0 in requirements-docs.in, since pulptools-iib still uses the now deprecated pkg_resources.
rbikar
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update cov testenv to generate coverage.xml report.
Adds the codecov action to the coverage workflow in tox-tests.yml.
Adds setuptools < 82.0.0 in requirements-docs.in, since pulptools-iib still uses the now deprecated pkg_resources.