fix(gameobjects): remove sound on arrow keypress#11
Open
SG-SWE073 wants to merge 1 commit into
Open
Conversation
remarkablemark
requested changes
Feb 20, 2024
remarkablemark
left a comment
Member
There was a problem hiding this comment.
I personally like the sound effect because it provides feedback that the key is pressed
When I play tested the change, it felt like something was missing: https://zeroupdates.rhythmism.pages.dev/
What do you think?
Collaborator
Author
|
Now that I consider it more, there's a few things to note.
So with this in mind, maybe we can hold off on the merge until we get more feedback from others, and if other players mention the sound is distracting, then we can discuss the update further. |
Member
|
@SG-SWE073 sounds goods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
What is the current behavior?
What is the new behavior?
Checklist: