feat: remove remaining lint warnings in event bus and ring buffer#3
feat: remove remaining lint warnings in event bus and ring buffer#3remcostoeten wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Hi @remcostoeten! 👋
Your private repo does not have access to Sourcery.
Please upgrade to continue using Sourcery ✨
📝 WalkthroughWalkthroughTwo modules refactored for improved implementation patterns. The event bus subscribe function now uses a named bucket alias for Set operations, while the performance logger replaces its buffer with a nullable variant and adds filtering logic to sanitize results. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Summary\n- removed non-null assertion from event bus unsubscribe path by capturing a stable listener bucket\n- replaced ring buffer
ew Array(capacity) allocation with typed Array.from initialization\n- preserved existing runtime behavior while eliminating remaining lint warnings\n\n## Validation\n- bun run check\n\n## Notes\n- this implements the quick win from o_implement.md under lint cleanup
Summary by CodeRabbit