Open
Conversation
SaveTheRbtz
reviewed
Jul 20, 2022
Comment on lines
+90
to
+94
| go func() { | ||
| defer close(done) | ||
| s.Wait() | ||
| done <- struct{}{} | ||
| }() |
Contributor
There was a problem hiding this comment.
this will leak goroutine each time WaitWithContext is called w/ an expired context until wg finishes.
Author
There was a problem hiding this comment.
Could document it as such? Given a context that has been cancelled, via os.Interrupt for example, I thought it better to orphan the goroutine and have the application exit when graceful immediate shutdown of all the goroutines in the sizedWaitGroup is not possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion to the
AddWithContext(context.Context)method to giveWaitthe same awareness of cancellation by a context.