Skip to content

Fix mistakes in README, improve formatting#14

Open
mpaw wants to merge 1 commit into
remrc:mainfrom
mpaw:patch-1
Open

Fix mistakes in README, improve formatting#14
mpaw wants to merge 1 commit into
remrc:mainfrom
mpaw:patch-1

Conversation

@mpaw

@mpaw mpaw commented Nov 15, 2024

Copy link
Copy Markdown
  • Fix mistake where the instructions state that the red connections must be connected when it actually should say blue connections must be connected
  • Improve instructions for manual calibration and add a table with commands and how much they offset the values
  • Fix grammatical errors and improve overall instructions

@mpaw

mpaw commented Nov 18, 2024

Copy link
Copy Markdown
Author

@remrc Let me know if you want me to make any changes

@mpaw

mpaw commented Nov 18, 2024

Copy link
Copy Markdown
Author

Here's a preview of the README with my changes
https://github.com/remrc/Self-Balancing-Cube/blob/4bd74179ce98a71107d4cb61bc073f48a263a718/README.md

@remrc

remrc commented Nov 18, 2024

Copy link
Copy Markdown
Owner

Where I say that the blue connections are not required?

@mpaw

mpaw commented Nov 19, 2024

Copy link
Copy Markdown
Author

@remrc Sorry, I quoted you incorrectly. What you actually said is

The red connections you see in the schematic must be connected!

But it should be

The blue connections you see in the schematic must be connected!

image

@mpaw

mpaw commented Nov 19, 2024

Copy link
Copy Markdown
Author

I updated the PR description to clarify what I meant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants