Add encoding parameter for non-ASCII characters#17
Open
kuihao wants to merge 1 commit intoremykarem:masterfrom
Open
Add encoding parameter for non-ASCII characters#17kuihao wants to merge 1 commit intoremykarem:masterfrom
encoding parameter for non-ASCII characters#17kuihao wants to merge 1 commit intoremykarem:masterfrom
Conversation
Fixed the `UnicodeDecodeError` issue in `p2j` when processing Python scripts with Chinese comments. Added an encoding parameter (default=“utf-8”) to handle character encoding. Resolves Issue remykarem#16.
remykarem
requested changes
Apr 21, 2024
Owner
There was a problem hiding this comment.
args.encoding should be passed to the encoding parameter that we're exposing in the functions jupyter2python and python2jupyter.
i.e.
if args.reverse:
jupyter2python(
...,
encoding=args.encoding
)
else:
python2jupyter(
...,
encoding=args.encoding
)Otherwise, the value of the encoding parsed from the CLI won't enjoy this new feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the
UnicodeDecodeErrorissue inp2jwhen processing Python scripts with Chinese comments. Added an encoding parameter (default=“utf-8”) to handle character encoding. Resolves Issue #16.Usage
Run code (OS is
windows 11):Expected output: