feat(student-onboarding): parede de clearance + gate (b) (Onda C)#156
Open
renanfulas wants to merge 1 commit into
Open
feat(student-onboarding): parede de clearance + gate (b) (Onda C)#156renanfulas wants to merge 1 commit into
renanfulas wants to merge 1 commit into
Conversation
…entrada (Onda C)
Empilhado na Onda B. Atras da flag STUDENT_CONSENT_GATE_ENABLED (default OFF).
- gate (b) em StudentIdentityRequiredMixin.dispatch: se o membership do box ativo
esta clearance_required e cleared_at IS NULL -> redireciona para a parede; pula
a propria rota (sem loop)
- StudentClearanceView + clearance.html: parede acolhedora, nao dead-end
("leve o atestado ao box <nome> e a equipe libera"); mostra display_name do box
- agora o aluno flagged e EFETIVAMENTE barrado da entrada (a Onda B so marcava
clearance_required); a liberacao manual por staff vem na Onda D
Validacao local (PG 5433): 25 passed (parede C + gate B + modelo A, --reuse-db):
flagged barrado, parede renderiza, cleared passa, clear nao ve parede, flag OFF no-op.
Ref: docs/plans/student-parq-waiver-entry-gate-corda.md (Onda C)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onda C — parede de clearance + gate (b)
Terceira onda do plano
docs/plans/student-parq-waiver-entry-gate-corda.md. Empilhada na Onda B (#155) — base aponta parafeat/student-consent-gate. Tudo atrás da flagSTUDENT_CONSENT_GATE_ENABLED(default OFF).O que entra
dispatch: se o membership do box ativo estáclearance_requiredecleared_at IS NULL→ redireciona para a parede; pula a própria rota (sem loop). Roda depois do gate (a) de consentimento.StudentClearanceView+clearance.html: parede acolhedora, não dead-end — "leve o atestado ao seu box {display_name} e a equipe libera seu acesso na hora". Mostra o nome do box.clearance_required; aqui o bloqueio passa a valer.Decisões honradas
dispatch), não treino.clearance_required/cleared_at): status do membership intacto, zero fan-out.Validação local (PG 5433)
pytest tests/test_student_consent_wall.py tests/test_student_consent_gate.py tests/test_student_consent_model.py --reuse-db→ 25 passed:cleared_atpassaPróximo
Onda D: ação de staff "Liberar acesso" (seta
cleared_at) + fila operacionalclearance_required=True, cleared_at IS NULL.🤖 Generated with Claude Code