Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| pub struct WalletPermission<AccountId> { | ||
| pub recipient: AccountId, | ||
| pub r#type: WalletScopeType, |
There was a problem hiding this comment.
This was converted by Polkadot.js to r_type, and in Serde, it would be just type. Even worse, Polkadot.js usually converts the fields to camel case, and in this case, there's this underscore _.
I think it's better for us to avoid using type or other keywords as identifiers if this is going to happen, to avoid inconsistencies in serialization/conversion at interfaces.
Alternatives: kind, variant, body.
Introduces a new permission type for controlling wallet stake.
Closes CHAIN-129.