ci: ensure example/ passes renovate-config-validator#962
Merged
Conversation
jamietanna
force-pushed
the
ci/validate
branch
from
6e739dd to
1398a2c
Compare
jamietanna
force-pushed
the
ci/validate
branch
from
1398a2c to
c2e09e0
Compare
viceice
reviewed
Nov 7, 2025
Member
viceice
left a comment
viceice
left a comment
There was a problem hiding this comment.
why not adding to existing workflows, to we can make mandatory. otherwise we'll still miss this
Contributor
Author
|
The thought here was to only run it when we're touching these files, so as not to run it unnecessarily - I can move it over and have conditional logic not to run if the files haven't changed? |
Member
sure, but validattion is fast and cheap, so i don't think a condition is required |
jamietanna
force-pushed
the
ci/validate
branch
from
c2e09e0 to
7786dc3
Compare
viceice
reviewed
Dec 15, 2025
jamietanna
force-pushed
the
ci/validate
branch
2 times, most recently
from
8a9e93a to
e6d23c9
Compare
jamietanna
force-pushed
the
ci/validate
branch
from
e6d23c9 to
a44890f
Compare
viceice
approved these changes
Dec 15, 2025
viceice
reviewed
Dec 15, 2025
jamietanna
force-pushed
the
ci/validate
branch
2 times, most recently
from
4b8dbed to
cba8e93
Compare
As noted in #910, we have invalid configuration shared as an example, which isn't ideal. We should validate any JSON and `config.js` files in the example directory. We need to make sure that we override the ESM settings in this repo, as otherwise we receive: module is not defined in ES module scope When trying to validate the `renovate-config.js`. This also follows the usage of a container from Renovate[0] for using the container to run the validator. [0]: https://github.com/renovatebot/.github/blob/2ab0f77818/.github/workflows/test.yml#L44
jamietanna
force-pushed
the
ci/validate
branch
from
cba8e93 to
a417869
Compare
viceice
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #910, we have invalid configuration shared as an example,
which isn't ideal.
We should validate any JSON and
config.jsfiles in the exampledirectory.
We need to make sure that we override the ESM settings in this repo, as
otherwise we receive:
When trying to validate the
renovate-config.js.This also follows the usage of a container from Renovate0 for using
the container to run the validator.