Escape table names for --only-indexes

[panga]

Currently, the --only-indexes option doesn't escape table names given in the command line and causes the following error:

LOG: (query) LOCK TABLE table-name IN ACCESS EXCLUSIVE MODE
ERROR:  syntax error at or near "-"
LINE 1: LOCK TABLE table-name IN ACCESS ...
                                            ^
ERROR: query failed: ERROR:  current transaction is aborted, commands ignored until end of transaction block

Example:

pg_repack -h SERVER -U USER -d DATABASE --echo --table='table-name' --only-indexes

Note: There's a workaround, you can add double quotes to the table name, however, this is something very easy to miss and cause the database become in an invalid state with a lot of indexes uncomplete rebuilt.

This PR change the SQL query used in bin/pg_repack and fix the issue.

[schmiddy]

Thanks for the proposed fix - but this sounds like a duplicate of #177. Although the behavior is ugly it is intentional.

[panga]

@schmiddy I understand. In this case, extra validation would be helpful to avoid issues and also some mention in the docs. Thank you

[za-arthur]

Thanks for the PR. It looks good to me.

Thanks for the proposed fix - but this sounds like a duplicate of #177. Although the behavior is ugly it is intentional.

I think that #177 solves the issue in a different way by enforcing quotes. On the other hand this PR changes internal behavior of how table name is retrieved which is used later:

pg_repack/bin/pg_repack.c

Line 2191 in 999b854

appendStringInfo(&sql, "LOCK TABLE %s IN ACCESS EXCLUSIVE MODE",

On the other hand it is probably worth to add new tests.