This repository was archived by the owner on May 2, 2024. It is now read-only.
feat(replicated-library): add preflight pre-install hook#78
Merged
Conversation
Contributor
Author
exampleoutput |
DexterYan
marked this pull request as draft
May 19, 2023 06:30
Contributor
|
This looks really cool, FYI we're looking at moving some file paths #80 this will impact where some of your files live. Just keep an eye on that PR. |
xavpaice
reviewed
May 19, 2023
|
|
||
| --- | ||
| apiVersion: v1 | ||
| kind: ServiceAccount |
Member
There was a problem hiding this comment.
suspect the service account, and RBAC roles, need to be setup using the library's RBAC tooling
Contributor
Author
|
if using it is working as expected when the pod is running success. However, if I am using The pod will fail, then the pod had been deleted automatically. However, sa, clusterrole, clusterrolebinding had not been deleted. Seems |
xavpaice
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another approach to add feature to sc-75516