feat: tests#3
Merged
Merged
Conversation
![replitmicromanager[bot]](https://avatars.githubusercontent.com/in/199493?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is too large for a good review. Requesting changes.
If there is no way to split this up, @lhchavez can approve.
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 18, 2025
Merged
darshkpatel
force-pushed
the
03-17-feat_tests
branch
2 times, most recently
from
22c5f8c to
c12bffc
Compare
darshkpatel
force-pushed
the
03-17-feat_tests
branch
from
c12bffc to
6497fc4
Compare
masad-frost
approved these changes
Mar 18, 2025
Member
masad-frost
left a comment
masad-frost
left a comment
There was a problem hiding this comment.
good place for snapshot tests 👍
darshkpatel
force-pushed
the
03-17-feat_tests
branch
from
6497fc4 to
af62291
Compare
darshkpatel
changed the base branch from
03-17-feat_implement_plugin
to
graphite-base/3
darshkpatel
added a commit
that referenced
this pull request
Mar 18, 2025
**Part of a [stack of PRs](#2 (comment) Allows us to do this now: <img width="611" alt="Screenshot 2025-03-18 at 10 15 31 AM" src="https://github.com/user-attachments/assets/b3dba9eb-ea85-4408-9200-0401a2e2d159" /> **Main Changes in this PR:** - Ports our [existing plugin](https://github.com/replit/repl-it-web/blob/main/graphql-codegen-pql-plugin/persisted-query-manifest-plugin.ts) while cleaning it up and making it more structured - also adding support for `includeAlgorithmPrefix` to help match the [graphql-over-http spec](https://github.com/graphql/graphql-over-http/blob/52d56fb36d51c17e08a920510a23bdc2f6a720be/spec/Appendix%20A%20--%20Persisted%20Documents.md#sha256-hex-document-identifier) this is still not implemented completely in the apollo graphql client so keeping it defaulted to false for now - eg. [relay decided to use md5 hashes](https://relay.dev/docs/guides/persisted-queries/) - core logic remains the same, doing cosmetic changes to make the package more maintainable - Test coverage in stacked PR: #3 - Did a quick sanity check by enabling the `includeAlgorithmPrefix` option and then turning it off, matches the existing generated manifest ( Note: I plan to use it without the algorithm prefix. ) 
darshkpatel
force-pushed
the
graphite-base/3
branch
from
f27b17d to
8e06c51
Compare
darshkpatel
force-pushed
the
03-17-feat_tests
branch
from
af62291 to
01d2cb7
Compare
darshkpatel
force-pushed
the
03-17-feat_tests
branch
from
01d2cb7 to
01db47c
Compare
Collaborator
Author
|
@replit/micromanager merge tests - pr exceeds 1k loc threshold due to generated snapshots |
|
of course @darshkpatel, I will merge it right away |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added test suite with Vitest and development documentation
I also have a stacked PR adding CI to run these tests 😃