Optimize Swift and TypeScript CodeMap pipelines#608
Merged
Conversation
baron
approved these changes
Jul 23, 2026
baron
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the full 4f6003b…2db7459d diff, including the Swift/JavaScript/TypeScript fast paths, referenced-type deduplication, instrumentation, build/guardrail changes, and legacy benchmark/prompt/highlighting removals. The removed preview-highlighting path was dead at the base with no consumer/render path. Fab independently reviewed the change and found no blocking defects. The lone CI failure was the known unrelated #161 flake; its rerun passed. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Swift deterministic 64-file corpus
Retained iterations:
TypeScript / TSX synthetic pipeline
The shared JSTS normalization leaf improved 15.5–19.7%. Exact TS/TSX captures and artifacts remained unchanged.
Rejected experiments
Validation
CodeMapQueryOptimizationBenchmarkTests: 25 passed, 1 expected skipRepoPromptandrepoprompt-mcpproduct builds passed; debug app packaged and relaunchedLive full-workspace measurement
The DEBUG
codemap_full_loadharness was armed against the freshly relaunched app and therepoprompt-ceworkspace. The workspace switch remained pending and did not reach authoritative CodeMap proof readiness within the raised 600-second diagnostic window. This PR therefore claims only the repeatable corpus improvements above; the remaining full-workspace load bottleneck is not represented as solved.Known unrelated inventory issue
The existing curated ledger verifier reports five missing IDs and zero stale IDs. This PR keeps that known discrepancy unchanged; all tests added or removed here have surgical ledger entries.