Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prepares a release by bumping the package version and introducing a debug mode feature. Key changes include:
- Updating the version in setup.py from 5.6.3 to 5.6.4.
- Adding a new "debug_mode" attribute to support detailed error logging in variables.py and propagating it in service.py.
- Documenting the RP_DEBUG_MODE configuration in the changelog.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Bumped version to 5.6.4. |
| robotframework_reportportal/variables.py | Added a debug_mode field and initialized it from RP_DEBUG_MODE. |
| robotframework_reportportal/service.py | Wrapped several methods in try/except blocks to log errors when debug is enabled. |
| CHANGELOG.md | Updated to document the new RP_DEBUG_MODE configuration. |
Comments suppressed due to low confidence (2)
robotframework_reportportal/service.py:135
- The new try/except block added for start_launch uses debug mode to log errors; please add tests to verify that error logging behaves correctly when debug mode is enabled.
try:
robotframework_reportportal/variables.py:139
- The initialization of debug_mode from RP_DEBUG_MODE is a new behavior; please add tests to confirm its behavior across different RP_DEBUG_MODE settings.
self.debug_mode = to_bool(get_variable("RP_DEBUG_MODE", default="False"))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.