EPMRPP-110768 || Adapt to the updated service-api#35
EPMRPP-110768 || Adapt to the updated service-api#35
Conversation
WalkthroughThe PR updates import paths across the Slack plugin codebase from the legacy package structure (e.g., Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
build.gradle (1)
33-33: Add a comment explaining the Shibboleth repository transitive dependency.The Shibboleth repository is needed as a transitive dependency of the updated
service-api(commit e81b4f6). Consider adding an inline comment to clarify this relationship for future maintainers:maven { // Required for transitive OpenSAML/Shibboleth dependencies via service-api url = "https://build.shibboleth.net/nexus/content/repositories/releases/" }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@build.gradle` at line 33, Add an inline comment above the maven repository declaration (the maven { url = "https://build.shibboleth.net/nexus/content/repositories/releases/" } block) explaining that this repository is required for transitive OpenSAML/Shibboleth dependencies brought in via the updated service-api (commit e81b4f6), so future maintainers understand why the Shibboleth repo is present even if not directly referenced.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@build.gradle`:
- Line 33: Add an inline comment above the maven repository declaration (the
maven { url =
"https://build.shibboleth.net/nexus/content/repositories/releases/" } block)
explaining that this repository is required for transitive OpenSAML/Shibboleth
dependencies brought in via the updated service-api (commit e81b4f6), so future
maintainers understand why the Shibboleth repo is present even if not directly
referenced.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 330baf3b-6288-4782-92b6-fd1b65adc011
📒 Files selected for processing (18)
build.gradlesrc/main/java/com/epam/reportportal/extension/slack/SlackPluginExtension.javasrc/main/java/com/epam/reportportal/extension/slack/collector/laucnh/AttributesCollector.javasrc/main/java/com/epam/reportportal/extension/slack/collector/laucnh/LaunchPropertiesCollector.javasrc/main/java/com/epam/reportportal/extension/slack/collector/laucnh/ResultColorCollector.javasrc/main/java/com/epam/reportportal/extension/slack/collector/laucnh/StatisticsPropertiesCollector.javasrc/main/java/com/epam/reportportal/extension/slack/event/launch/SlackLaunchFinishEventListener.javasrc/main/java/com/epam/reportportal/extension/slack/event/launch/resolver/AttachmentResolver.javasrc/main/java/com/epam/reportportal/extension/slack/event/launch/resolver/SenderCaseMatcher.javasrc/main/java/com/epam/reportportal/extension/slack/event/plugin/PluginLoadedEventHandler.javasrc/main/java/com/epam/reportportal/extension/slack/factory/PropertyCollectorFactory.javasrc/main/java/com/epam/reportportal/extension/slack/info/PluginInfoProvider.javasrc/main/java/com/epam/reportportal/extension/slack/info/impl/PluginInfoProviderImpl.javasrc/main/java/com/epam/reportportal/extension/slack/model/enums/SlackEventType.javasrc/main/java/com/epam/reportportal/extension/slack/model/enums/SlackIntegrationProperties.javasrc/main/java/com/epam/reportportal/extension/slack/utils/NotificationConfigConverter.javasrc/test/java/com/epam/reportportal/extension/slack/event/launch/SlackLaunchFinishEventListenerTest.javasrc/test/java/com/epam/reportportal/extension/slack/utils/MockData.java
Summary by CodeRabbit