Skip to content

EPMRPP-110768 || Adapt to the updated service-api#35

Open
Evelina02 wants to merge 1 commit intodevelopfrom
EPMRPP-110768-fix-paths
Open

EPMRPP-110768 || Adapt to the updated service-api#35
Evelina02 wants to merge 1 commit intodevelopfrom
EPMRPP-110768-fix-paths

Conversation

@Evelina02
Copy link
Contributor

@Evelina02 Evelina02 commented Mar 9, 2026

Summary by CodeRabbit

  • Chores
    • Added Maven repository to build configuration.
    • Refactored internal code organization and package structure across the codebase.
    • Updated dependency resolution for development and release modes.
    • Updated test suite and dependencies to align with restructured codebase.

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Walkthrough

The PR updates import paths across the Slack plugin codebase from the legacy package structure (e.g., com.epam.reportportal.infrastructure.*) to a new base package structure (e.g., com.epam.reportportal.base.infrastructure.*). Additionally, the build.gradle is updated to add a Maven repository and modify the service-api dependency resolution for non-release builds.

Changes

Cohort / File(s) Summary
Build Configuration
build.gradle
Added Maven repository (https://build.shibboleth.net/nexus/content/repositories/releases/) and updated non-release service-api dependency to com.github.reportportal:service-api:e81b4f6.
Plugin Extension & Event Handlers
src/main/java/com/epam/reportportal/extension/slack/SlackPluginExtension.java, src/main/java/com/epam/reportportal/extension/slack/event/plugin/PluginLoadedEventHandler.java
Updated imports for PluginUploadedEvent and persistence repositories to reference base package equivalents (com.epam.reportportal.base.*).
Launch Collectors
src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/AttributesCollector.java, src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/LaunchPropertiesCollector.java, src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/ResultColorCollector.java, src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/StatisticsPropertiesCollector.java
Updated imports for Launch, ItemAttribute, and StatusEnum to use base package paths.
Event Listeners & Resolvers
src/main/java/com/epam/reportportal/extension/slack/event/launch/SlackLaunchFinishEventListener.java, src/main/java/com/epam/reportportal/extension/slack/event/launch/resolver/AttachmentResolver.java, src/main/java/com/epam/reportportal/extension/slack/event/launch/resolver/SenderCaseMatcher.java
Updated imports for persistence DAOs and entities to reference base package equivalents.
Factory & Info Providers
src/main/java/com/epam/reportportal/extension/slack/factory/PropertyCollectorFactory.java, src/main/java/com/epam/reportportal/extension/slack/info/PluginInfoProvider.java, src/main/java/com/epam/reportportal/extension/slack/info/impl/PluginInfoProviderImpl.java
Updated imports for Launch and IntegrationType entities to use base package paths.
Enums & Utilities
src/main/java/com/epam/reportportal/extension/slack/model/enums/SlackEventType.java, src/main/java/com/epam/reportportal/extension/slack/model/enums/SlackIntegrationProperties.java, src/main/java/com/epam/reportportal/extension/slack/utils/NotificationConfigConverter.java
Updated imports for Integration, LaunchAttributeRule, and ItemAttributeResource to reference base package equivalents.
Test Files
src/test/java/com/epam/reportportal/extension/slack/event/launch/SlackLaunchFinishEventListenerTest.java, src/test/java/com/epam/reportportal/extension/slack/utils/MockData.java
Updated imports for repository and entity classes to use base package paths consistent with source code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • pbortnik
  • grabsefx

Poem

🐰 Hops with glee com.epam.reportportal.base!
Import paths dance to their new place,
From infrastructure to base we go,
Refactoring magic, watching it flow! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating import paths and dependencies to adapt to the reorganized service-api package structure (from infrastructure to base.infrastructure).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch EPMRPP-110768-fix-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
build.gradle (1)

33-33: Add a comment explaining the Shibboleth repository transitive dependency.

The Shibboleth repository is needed as a transitive dependency of the updated service-api (commit e81b4f6). Consider adding an inline comment to clarify this relationship for future maintainers:

maven { 
    // Required for transitive OpenSAML/Shibboleth dependencies via service-api
    url = "https://build.shibboleth.net/nexus/content/repositories/releases/" 
}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@build.gradle` at line 33, Add an inline comment above the maven repository
declaration (the maven { url =
"https://build.shibboleth.net/nexus/content/repositories/releases/" } block)
explaining that this repository is required for transitive OpenSAML/Shibboleth
dependencies brought in via the updated service-api (commit e81b4f6), so future
maintainers understand why the Shibboleth repo is present even if not directly
referenced.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@build.gradle`:
- Line 33: Add an inline comment above the maven repository declaration (the
maven { url =
"https://build.shibboleth.net/nexus/content/repositories/releases/" } block)
explaining that this repository is required for transitive OpenSAML/Shibboleth
dependencies brought in via the updated service-api (commit e81b4f6), so future
maintainers understand why the Shibboleth repo is present even if not directly
referenced.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 330baf3b-6288-4782-92b6-fd1b65adc011

📥 Commits

Reviewing files that changed from the base of the PR and between b66ca8e and 2d415b1.

📒 Files selected for processing (18)
  • build.gradle
  • src/main/java/com/epam/reportportal/extension/slack/SlackPluginExtension.java
  • src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/AttributesCollector.java
  • src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/LaunchPropertiesCollector.java
  • src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/ResultColorCollector.java
  • src/main/java/com/epam/reportportal/extension/slack/collector/laucnh/StatisticsPropertiesCollector.java
  • src/main/java/com/epam/reportportal/extension/slack/event/launch/SlackLaunchFinishEventListener.java
  • src/main/java/com/epam/reportportal/extension/slack/event/launch/resolver/AttachmentResolver.java
  • src/main/java/com/epam/reportportal/extension/slack/event/launch/resolver/SenderCaseMatcher.java
  • src/main/java/com/epam/reportportal/extension/slack/event/plugin/PluginLoadedEventHandler.java
  • src/main/java/com/epam/reportportal/extension/slack/factory/PropertyCollectorFactory.java
  • src/main/java/com/epam/reportportal/extension/slack/info/PluginInfoProvider.java
  • src/main/java/com/epam/reportportal/extension/slack/info/impl/PluginInfoProviderImpl.java
  • src/main/java/com/epam/reportportal/extension/slack/model/enums/SlackEventType.java
  • src/main/java/com/epam/reportportal/extension/slack/model/enums/SlackIntegrationProperties.java
  • src/main/java/com/epam/reportportal/extension/slack/utils/NotificationConfigConverter.java
  • src/test/java/com/epam/reportportal/extension/slack/event/launch/SlackLaunchFinishEventListenerTest.java
  • src/test/java/com/epam/reportportal/extension/slack/utils/MockData.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants