Update FetchAPI constructors#103
Merged
Merged
Conversation
nojaf
approved these changes
May 21, 2025
nojaf
left a comment
nojaf
left a comment
Member
There was a problem hiding this comment.
Thank you, looks good!
One small nit, I would like to avoid the KV abbreviation.
| /** | ||
| [Read more on MDN](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#setting_headers) | ||
| */ | ||
| external fromKVArray: array<(string, string)> => headersInit = "%identity" |
Member
There was a problem hiding this comment.
Suggested change
| external fromKVArray: array<(string, string)> => headersInit = "%identity" | |
| external fromKeyValueArray: array<(string, string)> => headersInit = "%identity" |
| */ | ||
| @new | ||
| external make2: (~init: any=?) => urlSearchParams = "URLSearchParams" | ||
| external fromKVArray: array<(string, string)> => urlSearchParams = "URLSearchParams" |
Member
There was a problem hiding this comment.
Suggested change
| external fromKVArray: array<(string, string)> => urlSearchParams = "URLSearchParams" | |
| external fromKeyValueArray: array<(string, string)> => urlSearchParams = "URLSearchParams" |
|
|
||
| let h2 = Headers.fromDict(dict{"X-Vegetable": "Carrot"}) | ||
|
|
||
| let h3 = Headers.fromKVArray([("X-Fruit", "Apple"), ("X-Vegetable", "Carrot")]) |
Member
There was a problem hiding this comment.
Suggested change
| let h3 = Headers.fromKVArray([("X-Fruit", "Apple"), ("X-Vegetable", "Carrot")]) | |
| let h3 = Headers.fromKeyValueArray([("X-Fruit", "Apple"), ("X-Vegetable", "Carrot")]) |
| params1->URLSearchParams.keys->Iterator.toArray->Array.forEach(Console.log) | ||
|
|
||
| let params2 = URLSearchParams.make3(~init="?foo=1&bar=b") | ||
| let params2 = URLSearchParams.fromKVArray([("foo", "1"), ("bar", "b")]) |
Member
There was a problem hiding this comment.
Suggested change
| let params2 = URLSearchParams.fromKVArray([("foo", "1"), ("bar", "b")]) | |
| let params2 = URLSearchParams.fromKeyValueArray([("foo", "1"), ("bar", "b")]) |
Contributor
Author
|
Thanks for your suggestion! |
Contributor
Author
|
How is |
Member
Hmm, you are suggesting to maybe reuse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.