Skip to content

WIP: ocamlformat 0.26.0#6360

Closed
cknitt wants to merge 1 commit into
rescript-lang:masterfrom
cknitt:ocamlformat
Closed

WIP: ocamlformat 0.26.0#6360
cknitt wants to merge 1 commit into
rescript-lang:masterfrom
cknitt:ocamlformat

Conversation

@cknitt

@cknitt cknitt commented Aug 20, 2023

Copy link
Copy Markdown
Member

Upgrade ocamlformat from 0.22.4 to 0.26.0 because

  • it seems the old version conflicts with the latest ocaml-lsp-server
  • the (few) formatting changes actually look like improvements

@cknitt cknitt changed the title ocamlformat 0.26.0 WIP: ocamlformat 0.26.0 Aug 20, 2023
@cknitt cknitt added this to the v12 milestone Aug 20, 2023
@cknitt

cknitt commented Aug 20, 2023

Copy link
Copy Markdown
Member Author

Seems that won't work because the new version is not in the OPAM repository used for Windows yet.

@cristianoc

Copy link
Copy Markdown
Collaborator

Seems that won't work because the new version is not in the OPAM repository used for Windows yet.

How about holding for a while then merge when ready.

@cknitt

cknitt commented Feb 1, 2024

Copy link
Copy Markdown
Member Author

Superseded by #6493.

@cknitt cknitt closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants